I did indeed not check for arctech old. It's just an assumption that arctech requires lsb = 1. (Lsb 2). Sartano requires lsb = 2 (lsb 3). Impuls requires a combination of 1 or 2 and 3 or 4 to be unique. The lsb is the different bit, not the one that is always the same or you will get 000000000000 or 111111111111 output. Hope that clears any confusion left.
Verzonden vanaf mijn BlackBerry®-toestel

-----Original Message-----
From: CurlyMoo <notifications@github.com>
Date: Sun, 18 Aug 2013 14:23:39 
To: pilight/pilight<pilight@noreply.github.com>
Reply-To: pilight/pilight <reply@reply.github.com>
Cc: Bram1337<bram1337@gmail.com>
Subject: Re: [pilight] Fixed the sartano receive bug (#30)

> @@ -660,7 +660,7 @@ void receive_code(void) {
>  						}
>  						if(protocol->header == 0) {
>  							header = (short)protocol->pulse;
> -							lsb = 1;
> +							lsb = 2; // lsb 1 for arctech_old, lsb 2 for sartano, impuls requires the checking of lsb 1 AND 2

Just for my information:

__sartano__
295 1180 295 1180 
295 1180 295 1180 
295 1180 295 1180 
295 1180 295 1180 
295 1180 295 1180 
295 1180 295 1180 
295 1180 1180 295 
295 1180 1180 295 
295 1180 1180 295 
295 1180 1180 295 
295 1180 295 1180 
295 1180 1180 295 
295 9920

__arctech_old__
295 1180 1180 295 
295 1180 1180 295 
295 1180 295 1180 
295 1180 1180 295 
295 1180 1180 295 
295 1180 1180 295 
295 1180 1180 295 
295 1180 1180 295 
295 1180 295 1180 
295 1180 1180 295 
295 1180 1180 295 
295 1180 1180 295 
295 11505 

As you can see, in both cases the LSB bit is bit 2. However, i thought we started counting from 0 so that's why i made the LSB 1 instead of 2? I also got confirmation from Martin in the arctech_old topic, that the original code worked. So i'm confused because both have the same structure.

If indeed, we need specific LSB settings per protocol, than i can add them to the protocol struct. However, i first want to see a raw impuls output to be sure.


---
Reply to this email directly or view it on GitHub:
https://github.com/pilight/pilight/pull/30/files#r5832521