Yeah, good point. I was trying not to touch the original too badly, but
I've already changed things around so much...


On Fri, Apr 19, 2013 at 12:54 PM, Mark Smith <notifications@github.com>wrote:

> In bin/worker/incoming-email:
>
> >
> > -        # failure, do we retry?
> > -        return $post_rv ? dequeue($post_msg) : retry($post_msg);
> > +        # on success: $status_msg eq 'Post success"
> > +        # on failure: $status_msg is something else
> > +        #             -- then we check $email_post->dequeue
> > +        return completed() if $status_msg =~ /success/;
>
> I am not a fan of depending on the textual content of a message. Instead,
> why don't you return a tuple? This is used in the payment system, i.e.,
> "return (1, 'status message')" that way the message can be opaque (and
> potentially translated in the future) and you always have a clear return
> value.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dreamwidth/dw-free/pull/346/files#r3867799>
> .
>