basic version needs test with different os