docs are a little unclear on attrs