I tend not to because it's easier to apply a clear cut rule without
exceptions for something this trivial - but we should decide as a team so
some classes won't have it while others do. I don't think checkstyle can
pick this up.
On 28 Nov 2013 16:10, "Paul Blundell" <notifications@github.com> wrote:

> In core/src/main/java/com/novoda/imageloader/core/LoaderSettings.java:
>
> > -        this.setExpirationPeriod(DEFAULT_EXPIRATION_PERIOD);
> > -        this.setQueryIncludedInHash(DEFAULT_INCLUDE_QUERY_IN_HASH);
> > -        this.setConnectionTimeout(DEFAULT_CONNECTION_TIMEOUT);
> > -        this.setReadTimeout(DEFAULT_READ_TIMEOUT);
> > -        this.setDisconnectOnEveryCall(DEFAULT_DISCONNECT_ON_EVERY_CALL);
> > -        this.setUseAsyncTasks(DEFAULT_USE_ASYNC_TASKS);
> > -        this.setAllowUpsampling(DEFAULT_ALLOW_UPSAMPLING);
> > -        this.setAlwaysUseOriginalSize(DEFAULT_ALWAYS_USE_ORIGINAL_SIZE);
> > +        bitmapUtil = new BitmapUtil();
> > +        headers = new HashMap<String, String>();
> > +
> > +        expirationPeriodInMillis = DEFAULT_EXPIRATION_PERIOD;
> > +        readTimeout = DEFAULT_READ_TIMEOUT;
> > +        connectionTimeout = DEFAULT_CONNECTION_TIMEOUT;
> > +
> > +        shouldIncludeQueryInHash = DEFAULT_INCLUDE_QUERY_IN_HASH;
>
> I still like this. in constructors, clearly you don't
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/novoda/ImageLoader/pull/148/files#r7988229>
> .
>