Bump version to 4.3.32

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
doc/contributing: New file

Partly inspired by GNU coreutils HACKING[*].

doc/coding section "git" is now redundant, except for the note on
avoiding whitespace changes.  Move that to section "Code formatting",
and delete section "git".

[*] http://git.savannah.gnu.org/cgit/coreutils.git/plain/HACKING?id=77da73c

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
doc/coding: Correct spelling mistakes

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
doc/README: Clarify description of file coding

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
version: Consistently end sentences with periods

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
Put URIs and e-mail addresses in <angle brackets>

Also end URIs with '/' where appropriate.

Refrain from touching scripts/ and Stephen Crane's LWP authorship
note.

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
info/version: Update example to current output

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
tcp_listen: Plug fd leak on OpenBSD with IPv6

Leaks one file descriptor per configured IPv6 address, which should be
pretty harmless.  Broken in commit da154ff, v4.3.31.

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
satmap: Separate and align columns in output properly

Land unit coordinates run into efficiency in output of satellite when
the y coordinate is wider than three characters.  Broken in Empire 2.
Restore the separating space.

Both ship and land unit table header aren't aligned with the table
body.  Affects recon and sweep with spy planes, and satellite.  Fix
the header.

Reported-by: William Fittge <ptkei2@gmail.com>
Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
land: Separate columns x,y and a in output properly

Coordinates run into army when the y coordinate is wider than three
characters.  Has always been broken.  Insert a separating space.

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
sorder: Widen coordinate columns to four characters

When formatting coordinates for fixed-width output, the width should
be at least four characters.

Columns x,y, start and end use three.  Has always been that way,
except for end, which used two until commit e07fb30 (v4.2.13).

Widen them all to four.  This cleans up output for world sizes between
200 and 1998.

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
mission: Widen coordinate columns to four characters

When formatting coordinates for fixed-width output, the width should
be at least four characters.

Columns x,y and op-sect use three.  Has always been that way.  Widen
them both to four.  This cleans up output for world sizes between 200
and 1998.

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
cutoff level: Add FIXME comments to narrow coordinate columns

When formatting coordinates for fixed-width output, the width should
be at least four characters.

cutoff was fine until 4.0.2 reduced coordinate width to three to make
space for civilian and military delivery thresholds.

level has always used width three.

Can't fix either without making lines too long or dropping
information, so just document the problem for now.

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
tests: Enable thread stack checking (emp_server -s)

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
tests: Cut off log file timestamp instead of normalizing it

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
client: Send login commands without trailing space

Cosmetical improvement; the server is just fine with trailing space.

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
tests: Capture player output via journal instead of client

Capturing the client's output tests both client and server, which is
nice.  However, player input isn't visible in the resulting file,
which makes it more difficult to understand.

Route player output to journal (econfig key "keep_journal 2"), and
ignore client output.

Separate tests for the client would be useful.

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
empdump: Don't abort() on unresolvable symbols

empdump flags them since commit 2a5d12b (v4.3.28), but still aborts.
Avoid the abort.

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
make: Drop unused support for parallel test runs

Tests can't run in parallel anyway, because they use uses a single
sandbox directory and a single TCP port.

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
tests/actofgod: New, disabled for now because it oopses

This is a fairly comprehensive test of the deity commands to edit game
state: edit, setresource, setsector, give, swapsector.

The test makes edit screw up game state, triggering oopses.  The
server refuses to start without -F then, and empdump -x warns "export
has errors, not importable as is".  Until these bugs are fixed, skip
this test in "make check".

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>