I actually spent some time thinking about whether it should be that string.
Since right now it is called by com_media and the string is there, I think
it should be this. We need to make a decision about whether to use JText in
the CMS folder. Unlike the framework we can basically assume that string
handling is in place so maybe it makes sense to continue the practice of
using JText here.


On Sun, Aug 25, 2013 at 9:52 PM, Michael Babker <notifications@github.com>wrote:

> In libraries/cms/helper/media.php:
>
> > +	/**
> > +	 * Checks if the file can be uploaded
> > +	 *
> > +	 * @param   array   $file  File information
> > +	 * @param   string  $err   An error message to be returned
> > +	 *
> > +	 * @return  boolean
> > +	 */
> > +	public function canUpload($file)
> > +	{
> > +		$params = JComponentHelper::getParams('
> com_media');
> > +
> > +		if (empty($file['name']))
> > +		{
> > +			$app = JFactory::getApplication();
> > +			$app->enqueueMessage(JText::_('COM_MEDIA_ERROR_UPLOAD_INPUT'), 'notice');
>
> Decouple strings from the component.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/joomla/joomla-cms/pull/1823/files#r5970503>
> .
>