Yes; the framework makes everything that's not marked as required=False to
be required, and the unit test calls into the registration framework by
just spitting a loaded dictionary at it, so it can't take advantage of the
defaults in the UI.

Besides making it so the tests could pass, I thought it would be a nice way
to document our intentions, so.

Joe

On Mon, Feb 11, 2013 at 9:07 PM, Jason Bau <notifications@github.com> wrote:

> In main/registration/forms.py:
>
> > -                                                                   ('----','-------------------'),
> > -                                                                   ('Software','In the software industry'),
> > -                                                                   ('Hardware','In the hardware industry'),
> > -                                                                   ('Legal','In the legal industry'),
> > -                                                                   ('K12','In K-12 education'),
> > -                                                                   ('PostSecondary','In post-secondary education'),
> > -                                                                   ('ArtsDesignArchEntertainment','In the arts, design, architecture or entertainment industries'),
> > -                                                                   ('LifePhysSci','In the life or physical sciences'),
> > -                                                                   ('Healthcare','In the healthcare industry'),
> > -                                                                   ('SocialServices','In social services'),
> > -                                                                   ('RetailServicesTransportationFood','In the retail service, transportation or food industries'),
> > -                                                                   ('ManufacturingConstruction','In manufacturing or construction'),
> > -                                                                   ('AnotherIndustry','In another industry'),
> > -                                                                   ('Other','Other'),))
> > +    birth_year = forms.ChoiceField(label=_("Year of birth"),
> > +                                   required=False,
>
> so: technically these dropdowns all have default values (being a select),
> so that why there was no required=False. Did doing this help pass the test?
> Just curious.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Stanford-Online/class2go/pull/2201/files#r2973744>.
>
>