Unreviewed. Change my email address.

* Scripts/webkitpy/common/config/committers.py:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133154 268f45cc-cd09-0410-ab3c-d52691b4dbfc
SVG as an image may recreate the renderer on zoom
https://bugs.webkit.org/show_bug.cgi?id=99508

Reviewed by Abhishek Arya.

Source/WebCore: 

The SVGImage code, when SVG is used in <img> tags, caches the renderer
at the start of the painting method and re-uses the pointer at the end
of the method. However, when the page is zoomed the renderer may be
detached mid-method, thus leaving a stray pointer. The fix is to
re-fetch the pointer after the zooms.

Test: svg/as-image/img-zoom-svg-stylesheet.html

* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawSVGToImageBuffer): Re-fetch the renderer after
the zoom operations.

LayoutTests: 

Test and ref-test-result for zooming of SVG content when loaded as-image, and the svg is actually a css file.

* svg/as-image/img-zoom-svg-stylesheet-expected.html: Added.
* svg/as-image/img-zoom-svg-stylesheet.html: Added.
* svg/as-image/resources/svg-stylesheet-for-zoom.svg: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133155 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[BlackBerry] Browser prematurely sends wrong credentials
https://bugs.webkit.org/show_bug.cgi?id=100585

Reviewed by George Staikos.

Don't send credentials to the server before been challenged.

* platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: Timeline: make "addRecord" unambiguous
https://bugs.webkit.org/show_bug.cgi?id=100761

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-01
Reviewed by Pavel Feldman.

TimelinePresentationModel.addRecord accepts two parameters:
record and parentRecord. parentRecord is always root record.
Make this explicit by removing parentRecord parameter.

* inspector/front-end/TimelinePanel.js: Removed parameter.
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.addRecord):
Used root recoed instead of parent record.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133157 268f45cc-cd09-0410-ab3c-d52691b4dbfc
FEImage::m_document is never cleared. Why not?
https://bugs.webkit.org/show_bug.cgi?id=99243

Reviewed by Dirk Schulze.

Adding a comment to explain why the failure to clear m_document is not a problem.

No new tests because no code change at all.

* svg/graphics/filters/SVGFEImage.h:
(FEImage): Add a comment on the lifetime of m_document.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-01

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133159 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix StylePropertySet/ElementAttributeData custom allocation in debug builds.
<http://webkit.org/b/100753>

Unreviewed debug bot crash fix after r133138.

There's additional padding after StylePropertySet and ElementAttributeData
in 64-bit debug builds since there are additional members in RefCountedBase.
Use 'sizeof(ImmutableFoo) - sizeof(void*)' as the base size of ImmutableFoo.

Patch by Andreas Kling <kling@webkit.org> on 2012-11-01

* css/StylePropertySet.cpp:
(WebCore::sizeForImmutableStylePropertySetWithPropertyCount):
* dom/ElementAttributeData.cpp:
(WebCore::sizeForImmutableElementAttributeDataWithAttributeCount):
(WebCore::ElementAttributeData::createImmutable):
(WebCore::ElementAttributeData::reportMemoryUsage):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Correct our use of the coordinated graphics
https://bugs.webkit.org/show_bug.cgi?id=100947

Reviewed by Alexis Menard.

Replace the display(...) call with a regular update() on the view.
In the coordinated graphics case this updates our view using
paintToCurrentGLContext with our viewmodel matrix and clips it to
the viewport. This avoid the need to manually joining update regions.

Unneeded update calls have also been removed and the resizing
logic has been improved.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::displayTimerFired):
(EwkViewImpl::update):
* UIProcess/API/efl/EwkViewImpl.h:
(WebCore):
(EwkViewImpl):
(EwkViewImpl::clearEvasGLSurface):
* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_calculate):
* UIProcess/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::setViewNeedsDisplay):
* UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::setVisibleContentsRect):
(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
(WebKit::PageViewportControllerClientEfl::didChangeVisibleContents):
* UIProcess/efl/PageViewportControllerClientEfl.h:
(PageViewportControllerClientEfl):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL][AC]Free GL resources allocated by GraphicsContext3DEfl.
https://bugs.webkit.org/show_bug.cgi?id=100923.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-11-01
Reviewed by Kenneth Rohde Christiansen.

GraphicsContext3DEfl creates FBO's, textures and render buffer's, but doesn't free them.
This patch makes sure that GraphicsContext3dEfl frees all the GL resources allocated by it.

* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::~GraphicsContext3D):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133162 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL][WK2] Add File Chooser dialog support to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=100822

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-01
Reviewed by Kenneth Rohde Christiansen.

Add very basic file picker dialog to MiniBrowser so that
the user can select a file from the file system when
clicking an input element of type "file".

* MiniBrowser/efl/main.c:
(close_file_picker):
(on_filepicker_deletion):
(on_fileselector_done):
(on_file_chooser_request):
(window_create):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133163 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Avoid attempting to defer commits when they are already deferred
https://bugs.webkit.org/show_bug.cgi?id=100913

Patch by James Robinson <jamesr@chromium.org> on 2012-11-01
Reviewed by Adrienne Walker.

In threaded compositing mode, it's possible to load and unload FrameViews without any
intervening invalidations. In this case, we enter setIsAcceleratedCompositingActive
with commits already deferred.  There's no need to defer again and doing so trips
an assertion in the implementation.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133164 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove empty directory after r132043.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133165 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[BlackBerry] Fix editing/text-iterator/findString-expected.html fail
https://bugs.webkit.org/show_bug.cgi?id=100902

Reviewed by Yong Li.

PR 210039

Fix the test my using the Page::findString method instead of our own in-page searcher.
This also syncs some of the changes we did regarding String usage.

* DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::dumpFramesAsText):
(BlackBerry::WebKit::dumpHistoryItem):
(BlackBerry::WebKit::dumpBackForwardListForWebView):
(BlackBerry::WebKit::DumpRenderTree::dump):
(BlackBerry::WebKit::DumpRenderTree::didFinishDocumentLoadForFrame):
(BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):
(BlackBerry::WebKit::DumpRenderTree::runJavaScriptAlert):
* DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
(DumpRenderTree):
* DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
(TestRunner::setMockGeolocationError):
(TestRunner::layerTreeAsText):
(TestRunner::findString):
(TestRunner::setStorageDatabaseIdleInterval):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r133143.
http://trac.webkit.org/changeset/133143
https://bugs.webkit.org/show_bug.cgi?id=96894

Causing content_browsertests failures

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DeviceOrientationClient.h:
(DeviceOrientationClient):
* dom/DeviceOrientationController.cpp:
(WebCore::DeviceOrientationController::DeviceOrientationController):
(WebCore):
(WebCore::DeviceOrientationController::~DeviceOrientationController):
(WebCore::DeviceOrientationController::timerFired):
(WebCore::DeviceOrientationController::addListener):
(WebCore::DeviceOrientationController::removeListener):
(WebCore::DeviceOrientationController::removeAllListeners):
(WebCore::DeviceOrientationController::suspendEventsForAllListeners):
(WebCore::DeviceOrientationController::resumeEventsForAllListeners):
(WebCore::DeviceOrientationController::didChangeDeviceOrientation):
(WebCore::DeviceOrientationController::supplementName):
* dom/DeviceOrientationController.h:
(WebCore):
(DeviceOrientationController):
(WebCore::DeviceOrientationController::isActive):
(WebCore::DeviceOrientationController::client):
(WebCore::DeviceOrientationController::from):
* dom/Document.cpp:
(WebCore::Document::suspendActiveDOMObjects):
(WebCore::Document::resumeActiveDOMObjects):
* loader/EmptyClients.h:
(WebCore::EmptyDeviceOrientationClient::startUpdating):
(WebCore::EmptyDeviceOrientationClient::stopUpdating):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):
* page/DeviceClient.h: Removed.
* page/DeviceController.cpp: Removed.
* page/DeviceController.h: Removed.

Source/WebKit/qt:

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setMockDeviceOrientation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133167 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Chromium] Unreviewed gardening.

Skipping http/tests/security/contentSecurityPolicy/object-src-none-blocked.html
as it's consistently leaking state into the next text (object-src-url-allowed.html).
Filed https://bugs.webkit.org/show_bug.cgi?id=100955 to follow up.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133168 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[V8] Unify the V8GCController visitors
https://bugs.webkit.org/show_bug.cgi?id=100897

Reviewed by Eric Seidel.

After this patch, we use a single visitor for all DOM wrappers,
regardless of type. We also visit all the wrappers in one pass by
calling v8::V8::VisitHandlesWithClassIds directly rather than via
visitAllDOMNodes.

This patch also introduces a wrapper class ID for non-Node DOM objects.
Previously, only DOM nodes had a class ID.

* bindings/v8/IntrusiveDOMWrapperMap.h:
* bindings/v8/ScriptProfiler.cpp:
(WebCore::retainedDOMInfo):
(WebCore::ScriptProfiler::initialize):
* bindings/v8/V8DOMMap.cpp:
(WebCore::visitAllDOMNodes):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
* bindings/v8/V8GCController.cpp:
(WebCore::GCHandleVisitor::notifyFinished):
(GCHandleVisitor):
(WebCore::V8GCController::majorGCPrologue):
* bindings/v8/WrapperTypeInfo.h:
(WebCore):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Fix event mapping for WebKit2 with coordinated graphics
https://bugs.webkit.org/show_bug.cgi?id=100956

Reviewed by Alexis Menard.

Apply scale after translation.

* UIProcess/API/efl/ewk_view.cpp:
(toWebContentTransform):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Chromium] Unreviewed gardening.  New reftest from
http://trac.webkit.org/changeset/133146 doesn't seem to work on
MacOS 10.8.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133171 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[subpixel] Change intrinsicSize to LayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=99104

Reviewed by Levi Weintraub.

Source/WebCore:

Change RenderReplaced and intrinsicSize to LayoutUnit to avoid
rounding problems when zooming/scaling. Also change imageSize to
LayoutUnit as it can return a scaled size.

Test: fast/sub-pixel/tiled-canvas-elements.html

* html/ImageDocument.cpp:
(WebCore::ImageDocumentParser::finish):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::imageSizeForRenderer):
* loader/cache/CachedImage.h:
(CachedImage):
* platform/graphics/FractionalLayoutSize.h:
(FractionalLayoutSize):
(WebCore::FractionalLayoutSize::scale):
(WebCore::FractionalLayoutSize::clampToMinimumSize):
* rendering/RenderBox.h:
(WebCore::RenderBox::intrinsicSize):
* rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::canvasSizeChanged):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged):
(WebCore::RenderImage::updateIntrinsicSizeIfNeeded):
(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::minimumReplacedHeight):
* rendering/RenderImage.h:
(RenderImage):
* rendering/RenderImageResource.h:
(WebCore::RenderImageResource::imageSize):
* rendering/RenderImageResourceStyleImage.h:
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::RenderReplaced):
(WebCore::RenderReplaced::computeAspectRatioInformationForRenderBox):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):
* rendering/RenderReplaced.h:
(RenderReplaced):
(WebCore::RenderReplaced::minimumReplacedHeight):
(WebCore::RenderReplaced::setIntrinsicSize):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updateIntrinsicSize):
(WebCore::RenderVideo::calculateIntrinsicSize):
(WebCore::RenderVideo::videoBox):
(WebCore::RenderVideo::minimumReplacedHeight):
* rendering/RenderVideo.h:
(RenderVideo):
* rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::imageSize):
* rendering/style/StyleCachedImage.h:
(StyleCachedImage):
* rendering/style/StyleCachedImageSet.cpp:
(WebCore::StyleCachedImageSet::imageSize):
* rendering/style/StyleCachedImageSet.h:
(StyleCachedImageSet):
* rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::imageSize):
(WebCore::StyleGeneratedImage::computeIntrinsicDimensions):
* rendering/style/StyleGeneratedImage.h:
(StyleGeneratedImage):
* rendering/style/StyleImage.h:
(StyleImage):
* rendering/style/StylePendingImage.h:

LayoutTests:

Add test for tiled replaced elements and update existing expectations as needed.

* fast/sub-pixel/tiled-canvas-elements-expected.txt: Added.
* fast/sub-pixel/tiled-canvas-elements.html: Added.
* platform/chromium-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
* platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
* platform/chromium-win/svg/as-image/svg-non-integer-scaled-image-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
* platform/chromium/fast/reflections/reflection-with-zoom-expected.txt:
* platform/chromium/svg/as-image/svg-non-integer-scaled-image-expected.txt:
* platform/chromium/svg/zoom/page/zoom-svg-as-image-expected.txt:
* platform/chromium/svg/zoom/page/zoom-svg-as-relative-image-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133172 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Chromium] Unreviewed gardening.  Remove some no-longer-flaky tests
from TestExpectations.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133173 268f45cc-cd09-0410-ab3c-d52691b4dbfc