Probably, if I implemented as you did with 3 classes.  However, more likely would have prefer erred 2 classes (a ViewModel and a Model equivalent to a row).  Maybe not int that case; depends on if I'd use the model (i.e. row) in other places (generally speaking, a view model is not very portable).

a

--

adam strickland : adam.strickland@gmail.com : 214.906.3350

On 17-Feb-2013, at 13:44 , John Lehmann <notifications@github.com> wrote:

> In src/timecalc.js:
> 
> > -      event.target.select();
> > -    };
> > -    this.cellBlur = function (data, event) {
> > -      // add row if the last row has a non-empty total
> > -      if (viewModel !== undefined && self === viewModel.getLastRow() && 
> > -          self.rowTotal() !== "") {
> > -        viewModel.addRow();
> > -      }
> > -    }
> > -  };
> > -
> > -  /**
> > -   * A single cell representing a time. Holds the observable which is in the
> > -   * view as well as the parsed value.
> > -   */
> > -  function InputTime(time, refInputTime) {
> @adamstrickland one specific question: would you break these three classes out into their own files? (I'm not asking @nezda since I know you're using a 5k line file on your program ;)
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>