webadmin: Refactoring gluster hook labels

Gluster hook command label is changed to 'Volume Event' and
unused constants are removed.

Change-Id: Ieed8b5176d484e49fe507bf3f1460447c5a9179e
Signed-off-by: Kanagaraj M <kmayilsa@redhat.com>
engine: Use proper method to mark net changes as saved

The patch reduces the need for updating the entire VdsDynamic
data by using a designated method for saving the dirty-network
indicator of the host.

Change-Id: Ib4c54214a275a1653c46bca7c95ff847975dd7d4
Signed-off-by: Moti Asayag <masayag@redhat.com>
core:we are fencing a host when putting it in...

we are fencing a host when putting it in maintenance after failed reinstall.

There are two commands that handle Host Maintenance

1) MaintenanceVdsCommand
2) MaintenanceNumberOfVdssCommand

In 1) there is handling in canDoAction that prevents the operation for
InstalledFailed status while this handling is omitted from 2)

I would expect that 2) will contain all validation checks done by 1) and
the best will be that they will call the same validation code. but this
is not the case right now.

To keep my change minimal and risk-less, I will have to copy the
relevant validation block from 1) code to 2)

Change-Id: I1ed67cb14b31597d147cee3a64056e3486f51d26
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=906389
Signed-off-by: Eli Mesika <emesika@redhat.com>
webadmin: move new disk logic to NewDiskModel

Move logic relevant only for new disk from
AbstractDiskModel to NewDiskModel.

Change-Id: If6bd49b1c513eb06d33a765738d5fd2587a88b13
Signed-off-by: Daniel Erez <derez@redhat.com>
core: Remove unused manifest from root webapp

The file src/resources/META-INF/MANIFEST.MF is not used, it is the
result of a mistake.

Change-Id: Ifbf46b718956b45029ab2c0479509688f82291f6
Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com>
webadmin: fix volume labels in ja and fr locale

Increased the width of Gluster Volume column in events tab
to avoid striping the label in ja locale.

Increased the height of the create volume dialog to avoid
the text overflowing in fr locale.

Bug-Url: https://bugzilla.redhat.com/950302
Change-Id: I6c831be1d3339bc293e1af46b1af2ead5de8ab6c
Signed-off-by: Kanagaraj M <kmayilsa@redhat.com>
core: VdsDAO.getAllWithName now returns instance

List<VDS> VdsDAO.getAllWithName(String) has been changed to
VDS VdsDAO.getByName(String) because VDS name is unique

Change-Id: I1a0cb37c98f1a4373028e6210e45261cd432eed3
Bug-Url: https://bugzilla.redhat.com/894382
Signed-off-by: Martin Perina <mperina@redhat.com>
userportal, weadmin: fix root pom

- fixed backend root pom, by removed extra dependency
that is not needed as commons-logging is properly
included already.

Change-Id: I2ca63b5346266ac0c15e385787adb881586fd029
Signed-off-by: Alexander Wels <awels@redhat.com>
core: prevent performing preview when the vm has illegal disks

When attempting to preview vm - do not allow to perform it when the vm
has illegal disks contained within the filtered disk list.

Change-Id: I8ee0e8070fb91bd2e0f18cf7bdb7a44aa51f70af
Bug-Url: https://bugzilla.redhat.com/949624
Signed-off-by: Liron Aravot <laravot@redhat.com>
core: clarify conditional expression in checkImageValidity

Add indentation and parenthesis to improve readability.

Change-Id: Ib82b97eb4670faa8ff456028fc89d23c6c2c79c2
Signed-off-by: Greg Padgett <gpadgett@redhat.com>
core: Remove GetAgentFenceOptions2Query

GetAgentFenceOptionsQuery and GetAgentFenceOptions2Query are completely
identical except for the usage of different APIs of VdsFenceOptions.

Since GetAgentFenceOptions is not used anywhere, it is removed, and
GetAgentFenceOptions2 loses it "2" and get a name the better suits
conventions (not to mention common sense).

This patch includes:
1. Removing the old GetAgentFenceOptionsQuery class and renaming
   GetAgentFenceOptions2Query to take its place.
2. Removing the old GetAgentFenceOptions constant in the VdsQueryTye
   enum, and renaming GetAgentFenceOptions2 to take its place.
3. Clearing up the VdsFenceOptions class from methods with "2" in their
   name - either by removing unused methods, or by renaming them to a
   more sensible name.

Change-Id: Id2d7f15c16257f39f162b52d22f7c2faf8eb291a
Signed-off-by: Allon Mureinik <amureini@redhat.com>
webadmin: Unused field in ConfigureLocalStorageModel

Removed the unused field
ConfigureLocalStorageModel.Context.candidate.

Change-Id: Ic90f950dfc9b02f1e7beb7939814b0f0c82e2c66
Signed-off-by: Allon Mureinik <amureini@redhat.com>
engine: Disable gluster hook - constants and messages

Adding constants and messages required by disable gluster
hook BLL and VDS commands.

Change-Id: I8776106ee00441b82f29a1fb9282123805369d66
Signed-off-by: Sahina Bose <sabose@redhat.com>
engine: VDS disable gluster hook command

Added VDS command to disable a gluster hook
on a server given the hook details - gluster command,
stage and hook name

Change-Id: I65c11b9406673d5dd5bcf648f2ce18b8e9f9d259
Signed-off-by: Sahina Bose <sabose@redhat.com>
engine: Disable gluster hook command

Added bll command to disable gluster hook on all
servers in a cluster.
This command extends from GlusterHookStatusChangeCommand
which does the work of calling the VDS command for each
of the server in the cluster.
The command succeeds if atleast one of the servers returns
success.

Refactored enable and disable hook tests to extend
from a common class.

Change-Id: I6fb3e034013d2ceb3590a61efc9bc46b1c3f378f
Signed-off-by: Selvasundaram <sesubram@redhat.com>
Signed-off-by: Sahina Bose <sabose@redhat.com>
engine: enable/disable hooks -use GlusterMultipleActionRunner

Changed factory to use GlusterMulitpleActionRunner for
Enable/Disable hooks

Change-Id: I702296e95491cb9770dc235bd2f4f0cb1eaa822e
Signed-off-by: Sahina Bose <sabose@redhat.com>
engine: test for AddVdsCommand

Adds test for canDoAction.

Change-Id: Iaa8b31e3bb4f96e34d7ea7e97ec8c4c5b1f19984
Signed-off-by: Laszlo Hornyak <lhornyak@redhat.com>
tools: notifier startup script startup directory

The notification daemon startup script attempts to change to the ovirt
user home directory to avoid permissions errors.  This directory doesn't
always exist, so it will now use / as a fallback.

Change-Id: Iba8b163881bd31eeb970da82003dd184ffcad9b9
Bug-Url: https://bugzilla.redhat.com/949975
Signed-off-by: Greg Padgett <gpadgett@redhat.com>
core: TryBackToAllSnapshots - avoid attempt to remove illegal disks

In change I8ee0e807 previewing a snapshot of vm with illegal disks was
blocked, so we will never actually remove any illegal disks as if there
were some - the action would have failed in the CDA phase.

Related-To: https://bugzilla.redhat.com/949624
Change-Id: Ie59bb1de3e9431998c9aa5269e3b65de8165dee9
Signed-off-by: Liron Aravot <laravot@redhat.com>
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: Update maven-war-plugin and maven-ear-plugin

This change updates the maven-war-plugin version to 2.2 and the
maven-ear-plugin version to 2.8. This update is required in order to use
the packagingIncludes and packagingExcludes configuration parameters
that are silently ignored in previous versions.

Change-Id: Iffc6ac741d4bb864246f67ea5c1e207013b96405
Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com>