Hey Aaron,

Sorry about that - got a little too excited, ha. Thanks heaps for the
feedback, greatly appreciated. I'll get onto those things right away.

Thanks again,

Hannah

On Thu, Jan 24, 2013 at 6:46 PM, Aaron Thornton <notifications@github.com>wrote:

> In app/views/groups/_membership_request.html.haml:
>
> > @@ -2,7 +2,6 @@
> >    .clearfix
> >      .membership-user-name= truncate(membership_request.user_name, :length => 29, :omission => '...')
> >      .admin-controls
> > -      =link_to 'Approve', approve_request_for_membership_path(membership_request), :method => :post,
> > -        :data => { :confirm => "Are you sure you want to add #{membership_request.user_email} to the group?" }
> > -      =link_to "×", ignore_request_for_membership_path(membership_request), :method => :post, class: 'close',
> > -        :data => {:confirm => "Are you sure you want to ignore the member request from #{membership_request.user_email}?" }
> > +      =link_to "Approve", "#", 'data-title' => "Approve", 'data-body' => "Are you sure you want to add #{membership_request.user_email} to the group?", 'data-confirm-path' => approve_request_for_membership_path(membership_request), 'data-method-type' => 'put', class: 'confirm-dialog', id: 'approve'
> > +      =link_to "×", "#", 'data-title' => "Ignore request", 'data-body' => "Are you sure you want to ignore the member request from #{membership_request.user_email}?", 'data-confirm-path' => ignore_request_for_membership_path(membership_request), 'data-method-type' => 'put', class: 'confirm-dialog close', id: 'ignore'
> > +
>
> One last comment. The trello card, actually describes the leave group
> action as part of the bug. It seems like you may have missed fixing this
> part of the problem.
> Great work though, all of the above is something for you to take your time
> with and learn form, not critisism in the slightest.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/enspiral/loomio/pull/453/files#r2753980>.
>
>