1. The comment in the django template is right: this is code that should never be reached due to the auth decorator, so it's not really a worry.

2. I will look into the logic behind 'default_login' to see.  I suspect it's probably very similar to what the "registration/login_link.html" does.

On Jan 25, 2013, at 2:13 AM, Sef Kloninger <notifications@github.com> wrote:

> In main/templates/videos/edit.html:
> 
> > @@ -56,11 +56,8 @@
> >  	  <a href="{% url 'courses.videos.views.list' common_page_data.course_prefix common_page_data.course_suffix %}" class="btn">Cancel</a>
> >  	</div>
> >        </form>
> > -  {% else %} {# This is technically unreachable due to admin decorator, but doing this just to be complete #}
> > -    <h4>Please {% with login_course=common_page_data.course login_link_id="login_link" link_text="log in" %}
> > -        {% include "registration/login_link.html" %}
> > -        {% endwith %}
> > -        to edit video.</h4>
> > +  {% else %}
> > +    <h4>Please <a data-toggle="modal" href="{% url 'default_login' %}?next={{ request.get_full_path }}">log in</a> to edit videos.</h4>
> There are four of these changes, in code that you recently touched @jbau. Not sure about that. Are these mistakes?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>