Le 16/01/2013 14:07, Jonathan Clarke a écrit :
>
> In
> inventory-fusion/src/main/scala/com/normation/inventory/provisioning/fusion/FusionReportUnmarshaller.scala:
>
> >          logger.debug(m)
> > -        None
> > -      case Some(slot) =>  
> > +        "1"
>
> Wouldn't it make more sense to use -1 here, to indicate "I don't
> know", rather than use a possibly valid slot number?
>

I wondered, but then there is the case where Fusion report two time the
same slot, or no slot, that have to be handle differently whereas here,
they are in the same case.
Well, I could use "-1", "-2" etc for duplicated slot number, and so
would nicely handle le case where reported slot number are 1, 2, 2 (or
1, nothing, nothing).

I'm going to open a ticket for that.

-- 
Francois