Jie:

I agree, there is no strong reason to have the makefile/makefile.rules split for Maple.

I have brought back ‘Makefile’ which now includes makefile and makefile.rules both of which are now deleted.

Regarding the automatic setting of PIN_ROOT, I consulted a Pin developer and found out that PIN_ROOT was getting overwritten in one of the Pin-provided config files. While this will be fixed in future Pin releases, I am releasing a new *PinPlay* kit (version 1.2) soon to fix this (since PinPlay kit is a copy [superset] of regular Pin kit). However, this means PinPlay version 1.2 or higher will be required to work with Maple (changed README.md to reflect that).

Will handle your other suggestions and then push an update.

Thanks,

-Harish

From: Jie Yu [mailto:notifications@github.com]
Sent: Monday, November 25, 2013 12:51 PM
To: jieyu/maple
Cc: Patil, Harish
Subject: Re: [maple] PinPlay enabled Maple (#14)


In makefile:

> @@ -0,0 +1,17 @@

> +##############################################################
Harish, Maple is not simply a PIN tool. It contains several other components (e.g. cmdline tools). The Makefile is responsible for compiling them too. Therefore, I don't see a strong reason we should stick with the PIN protocol. Can you modify pin.mk instead? (Basically the same stuff you have done in makefile). Regarding PIN_ROOT, i think you can just do PIN_ROOT := PIN_HOME Let me know if this does not work. - Jie
…
On Mon, Nov 25, 2013 at 4:16 AM, hgpatil <notifications@github.com> wrote: In makefile: > @@ -0,0 +1,17 @@ > +############################################################## Hi Jie: The makefile + makefile.rules split is in accordance to (new) Pin's makefile Infrastructure< http://software.intel.com/sites/landingpage/pintool/docs/62141/Pin/html/index.html#MAKEFILES> . I can rename makefile-->Makefile but would rather retain the split so in case the Pin team changes the recommended ‘makefile’ we will be ok. What do you think? Regarding setting PIN_ROOT in the makefile, I tried this: PIN_ROOT := $(shell echo $$PIN_HOME) However, that is not having the desired effect. Do you see what is wrong with this? Thanks. -Harish From: Jie Yu [mailto:notifications@github.com] Sent: Monday, November 25, 2013 1:43 AM To: jieyu/maple Cc: Patil, Harish Subject: Re: [maple] PinPlay enabled Maple (#14<https://github.com/jieyu/maple/pull/14><https://github.com/jieyu/maple/pull/14><https://github.com/jieyu/maple/pull/14%3e>) In makefile: @@ -0,0 +1,17 @@ +############################################################## Can we combine 'makefile' with 'makefile.rules'? Also, I would prefer 'Makefile':) — Reply to this email directly or view it on GitHub< https://github.com/jieyu/maple/pull/14/files#r7883709>. — Reply to this email directly or view it on GitHub<https://github.com/jieyu/maple/pull/14/files#r7889095> .

—
Reply to this email directly or view it on GitHub<https://github.com/jieyu/maple/pull/14/files#r7898452>.