Done. :)


2013/6/24 Fritz Obermeyer <notifications@github.com>

> In projection.C:
>
> > -            glPixelTransferf(GL_BLUE_SCALE, 0.33333333f);
> > -            glFinish();
> > -            glReadPixels(0,0,w,h, GL_LUMINANCE, GL_UNSIGNED_BYTE, image);
> > -        } else {
> > -            //faster; ends up with very fewer shades
> > -            glPixelTransferf(GL_RED_SCALE,  1.0f);
> > -            glPixelTransferf(GL_GREEN_SCALE,1.0f);
> > -            glPixelTransferf(GL_BLUE_SCALE, 1.0f);
> > -            glAccum(GL_LOAD, 1.0f);
> > -            glAccum(GL_RETURN, 0.3333333f);
> > -            glFinish();
> > -            glReadPixels(0,0,w,h, GL_LUMINANCE, GL_UNSIGNED_BYTE, image);
> > -            glAccum(GL_RETURN, 1.0f);
> > -        }
> > -    }
> > +    bool t_type=(!in_color)&&(!high_quality);
>
> The cleanup looks good, but these variable names could back more
> suggestive. I'd rename 't_type' to 'accumulating' and 't_scale' to
> 'transfer_scale' or just 'scale'.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/fritzo/jenn3d/pull/2/files#r4834842>
> .
>