[EFL][WK2] REGRESSION(r143582): API test EWK2UnitTestBase.ewk_view_contents_size_changed failing
https://bugs.webkit.org/show_bug.cgi?id=110608

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-06
Reviewed by Kenneth Rohde Christiansen.

Test was expecting ContentsSizeChanged signal from ViewClientEfl, but
WebView was not calling client callback if useFixedLayout() is true.

This patch prevent early return if useFixedLayout() is true and call
client callback didChangeContentsSize(), which will emit the signal.

* UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::didChangeContentsSize):
* UIProcess/efl/WebView.cpp:
(WebKit::WebView::didChangeContentsSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Use SkTypeface API directly, rather than (soon to be private) SkFontHost
https://bugs.webkit.org/show_bug.cgi?id=111588

Reviewed by Stephen White.

No new tests, as existing tests in fast/writing-mode exercise this code.

e.g. japanese-rl-text-with-broken-font.html
     vertical-subst-font-vert-no-dflt.html

* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::emSizeInFontUnits):
(WebCore::FontPlatformData::openTypeTable):
* platform/graphics/harfbuzz/HarfBuzzFaceSkia.cpp:
(WebCore::harfBuzzSkiaGetTable):
(WebCore::HarfBuzzFace::createFace):
* platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformInit):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[BlackBerry] Selection handles don't drag to expand correctly for RTL languages
https://bugs.webkit.org/show_bug.cgi?id=111618

Reviewed by Rob Buis.

PR 303712
If we are using a RTL language, we should ensure that the selection handles are angled the right way.
Further, when expanding the selection, the start and end handles should be appropriately set so that
expansion in the natural direction is possible.

Internally reviewed by Mike Fenton.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::SelectionHandler):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
* WebKitSupport/SelectionHandler.h:
(SelectionHandler):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] |m_gestureScrollOnImplThread| is not reset to false following the end of a fling on the fast path
https://bugs.webkit.org/show_bug.cgi?id=111390

Reviewed by James Robinson.

If there is a fast path gesture scroll which turns into a fling, the member
|m_gestureScrollOnImplThread| is not reset to false once the fling ends. As a
result, GestureScrollUpdate events belonging to a subsequent scroll are always
handled on the fast path, even if they should have been handled on the slow
path instead.

* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling):
* src/WebCompositorInputHandlerImpl.h:
(WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::isGestureScrollOnImplThread):
* tests/WebCompositorInputHandlerImplTest.cpp:
(WebKit::TEST_F):
(WebKit):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed gardening.

* platform/chromium/TestExpectations: svg/custom/foreign-object-skew.svg

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[GTK][WK2] Implement WebInspector::localizedStringsURL() to return the file URL of localizedStrings.js
https://bugs.webkit.org/show_bug.cgi?id=111448

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-06
Reviewed by Alexey Proskuryakov.

Implement WebInspector::localizedStringsURL() method to return the
file URL of the localizedStrings.js.

This prevents printing warnings about "Localized string not found" in
the console.

* WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspector::localizedStringsURL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed gardening.

* platform/chromium/TestExpectations: svg/css/font-face-crash.html

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed gardening of AppleWin port.

* platform/win/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed.  Rolled Chromium DEPS to r186511.  Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-06

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed gardening.

* platform/chromium/TestExpectations: compositing/rtl/..

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore: Modify log method in V8DOMActivityLogger so that the apiName and
extraInfo arguments are of type const String& instead of const char*.
This change gets rid of some of the memory ownership issues that arise
with char* pointers.
https://bugs.webkit.org/show_bug.cgi?id=111483

Patch by Ankur Taly <ataly@google.com> on 2013-03-06
Reviewed by Adam Barth.

There are no new tests as there is no change in behavior.

* bindings/v8/V8DOMActivityLogger.h:
(WebCore::V8DOMActivityLogger::log):

Source/WebKit/chromium: Modify log method in WebDOMActivityLogger so that the apiName and
extraInfo arguments are of type const WebString& instead of const char*.
This change gets rid of some of the memory ownership issues that arise
with char* pointers.
https://bugs.webkit.org/show_bug.cgi?id=111483

Patch by Ankur Taly <ataly@google.com> on 2013-03-06
Reviewed by Adam Barth.

There are no new tests as there is no change in behavior.

* public/WebDOMActivityLogger.h: Added property svn:eol-style.
(WebKit::WebDOMActivityLogger::log):
* src/WebDOMActivityLogger.cpp: Added property svn:eol-style.
(WebKit::DOMActivityLoggerContainer::log):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144988 268f45cc-cd09-0410-ab3c-d52691b4dbfc
DFG::AbstractState::merge() is still more complicated than it needs to be
https://bugs.webkit.org/show_bug.cgi?id=111619

Reviewed by Mark Hahnenberg.
        
This method is the one place where we still do some minimal amount of liveness pruning, but the style with
which it is written is awkward, and it makes an assertion about variablesAtTail that will be invalidated
by https://bugs.webkit.org/show_bug.cgi?id=111539.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::merge):
(JSC::DFG::AbstractState::mergeVariableBetweenBlocks):
* dfg/DFGAbstractState.h:
(AbstractState):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144989 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Build fix. Fixes problems building code that uses deprecated functions from GTK+ 2,
such as RenderThemeGtk2.cpp, in debug mode. RenderThemeGtk2.cpp tries to allow usage
of deprecated functions by undefining GTK_DISABLE_DEPRECATED, but it ended up being
redefined because autotoolsconfig.h was included again by headers that came after
config.h.

Reviewed by Martin Robinson.

* Source/autotools/SetupWebKitFeatures.m4: add checks to ensure the
autotoolsconfig.h header is only included once.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, roll out http://trac.webkit.org/changeset/144989
        
I think we want the assertion that I removed.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::merge):
(JSC::DFG::AbstractState::mergeVariableBetweenBlocks):
* dfg/DFGAbstractState.h:
(AbstractState):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144991 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[V8] Use implicit references instead of object groups to keep registered MutationObservers alive
https://bugs.webkit.org/show_bug.cgi?id=111382

Reviewed by Adam Barth.

.:

* ManualTests/mutation-observer-leaks-nodes.html: Added.

Source/WebCore:

Two-phase approach to implicit references: after grouping objects
together, add an implicit reference between each registered node's
group and the MutationObserver's group (which includes wrappers from
all worlds).

Also changed many uses of v8::Value to v8::Object where we know we're
dealing with Object and the V8 API expects them.

Test: ManualTests/mutation-observer-leaks-nodes.html

* bindings/v8/V8GCController.cpp:
(WebCore::ImplicitConnection::ImplicitConnection):
(WebCore::ImplicitConnection::wrapper):
(ImplicitConnection):
(WebCore::ImplicitReference::ImplicitReference): Wrapper class holding a parent who should have an implicit reference to a child.
(ImplicitReference):
(WebCore::operator<): Needed for std::sort() call to avoid the overhead of using a HashMap
(WebCore::WrapperGrouper::addObjectWrapperToGroup):
(WebCore::WrapperGrouper::addNodeWrapperToGroup):
(WebCore::WrapperGrouper::addImplicitReference):
(WrapperGrouper):
(WebCore::WrapperGrouper::apply):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144994 268f45cc-cd09-0410-ab3c-d52691b4dbfc
InsertUnorderedList can lead to lost content and assertions in moveParagraphs
https://bugs.webkit.org/show_bug.cgi?id=111228

Reviewed by Ryosuke Niwa.

Source/WebCore:

When a list is wrapped in a presentational inline like a b tag, we'd create markup that included
everything up to the b tag from moveParagraphs when intending to only move the contents of the
list item. This could make it impossible to remove content from a list and trigger loss of
editable text.

Test: editing/execCommand/insert-remove-block-list-inside-presentational-inline.html

* editing/EditingStyle.cpp:
(WebCore::elementMatchesAndPropertyIsNotInInlineStyleDecl): Ensure there's an inline style
before calling propertyExistsInStyle.
(WebCore::HTMLElementEquivalent::propertyExistsInStyle): Removing null check for style.
All callers ensure this value isn't null.
* editing/markup.cpp:
(WebCore::highestAncestorToWrapMarkup): Avoid going over RenderBlocks when finding the highest
presentational ancestor to avoid leaving the bounds of the original paragraph.

LayoutTests:

* editing/deleting/pruning-after-merge-1-expected.txt:
* editing/execCommand/insert-remove-block-list-inside-presentational-inline-expected.txt: Added.
* editing/execCommand/insert-remove-block-list-inside-presentational-inline.html: Added.
* editing/pasteboard/paste-and-sanitize-expected.txt:
* editing/pasteboard/paste-and-sanitize.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144995 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ASSERTION FAILED: m_tokenizer->state() == HTMLTokenizer::DataState
https://bugs.webkit.org/show_bug.cgi?id=110546

Unreviewed change to test expectations while the above bug is open.

* platform/mac/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Re-enable WinEWS test and decrease iterations before clean build back to 10.

* EWSTools/start-queue-win.sh:
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed gardening.

* platform/chromium/TestExpectations: fast/dom/Window/window-special-properties.html

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
editing/pasteboard/paste-4035648-fix.html should be a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=111639

Reviewed by Levi Weintraub.

Converted the test. Also renamed it to line-feed-between-br-and-b-should-not-reorder-pasted-content.html
to reflect the semantics of the test, and also added more description per radar bug.

* editing/pasteboard/line-feed-between-br-and-b-should-not-reorder-pasted-content-expected.txt: Added.
* editing/pasteboard/line-feed-between-br-and-b-should-not-reorder-pasted-content.html: Copied from
LayoutTests/editing/pasteboard/paste-4035648-fix.html.
* editing/pasteboard/paste-4035648-fix.html: Removed.
* platform/chromium-linux/editing/pasteboard/paste-4035648-fix-expected.png: Removed.
* platform/chromium-mac-lion/editing/pasteboard/paste-4035648-fix-expected.png: Removed.
* platform/chromium-mac/editing/pasteboard/paste-4035648-fix-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-4035648-fix-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-4035648-fix-expected.txt: Removed.
* platform/chromium/editing/pasteboard/paste-4035648-fix-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-4035648-fix-expected.png: Removed.
* platform/gtk/editing/pasteboard/paste-4035648-fix-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-4035648-fix-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-4035648-fix-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-4035648-fix-expected.png: Removed.
* platform/qt/editing/pasteboard/paste-4035648-fix-expected.txt: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144999 268f45cc-cd09-0410-ab3c-d52691b4dbfc