Should I rename this library java_opts?
On Mar 25, 2013 8:36 PM, "Xabier de Zuazo" <notifications@github.com> wrote:

> In lib/jvmargs/args.rb:
>
> >        end
> > -      percent_int = JVMArgs::Util.get_system_ram_m.sub(/M/,'').to_i
> > -      percentage_ram = (percent_int * percent).to_i
> > -      @args[:nonstandard]["Xmx"] = JVMArgs::NonStandard.new("-Xmx#{percentage_ram}M")
> > -      @args[:nonstandard]["Xms"] = JVMArgs::NonStandard.new("-Xms#{percentage_ram}M")
> > +      @args[:nonstandard]["Xmx"] = JVMArgs::NonStandard.new("-Xmx#{size_ram}")
> > +      @args[:nonstandard]["Xms"] = JVMArgs::NonStandard.new("-Xms#{size_ram}")
> > +    end
> > +
> > +    def permgen(size)
> > +      size_ram = JVMArgs::Util.convert_to_m(size)
> > +      # @args[:unstable]["PermSize"] = JVMArgs::Unstable.new("-XX:PermSize=#{size_ram}")
> > +      @args[:unstable]["MaxPermSize"] = JVMArgs::Unstable.new("-XX:MaxPermSize=#{size_ram}")
>
> I'm not sure if setting both *PermSize* and *MaxPermSize* would be better.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bryanwb/jvmargs/pull/3/files#r3519246>
> .
>