modify sth for better changing the parameters