PERF: disable parsing GE private tag identifying B-value in DWI acquisitions, since it can be present in non-DWI series, and parsing it involves running dcmdump


git-svn-id: http://svn.slicer.org/Slicer4/trunk@22169 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Fix launcher settings to allow loading of extension in unix build tree

This commit restores the correct loading of extension installed in a Slicer
build tree. It contains a fix related to ITKv4 transition and fix related
to transition from DCMTK static libraries to shared libraries (r21914)

Following the transition to ITKv4, the libraries (*.so) were built in the
lib directory [1] whereas in ITKv3, the libraries were built in the bin
directory [2].

[1] https://github.com/Kitware/ITK/blob/1839b74bacfd455dd917b086466c882ed29606ba/CMakeLists.txt#L164-174
[2] https://github.com/Kitware/ITK/blob/v3.20.1/CMakeLists.txt#L93-99

Following the transition to using DCMTK shared libraries (r21914 [3]), a
follow-up commit (r21942 [4]) has been pushed to ensure Slicer could be
started from a build tree on windows.

[3] http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21914
[4] http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21942

In both case (ITKv4 and DCMTK), Slicer could be started successfully from
a build tree on Windows (thanks to the launcher settings), and started
successfully on Unix system (thanks to rpath). On the other hand, since
the launcher settings were incorrect on unix system, the loading of
installed extensions (having rpath stripped) in a unix build tree was
failing.

Fixes #3218

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22170 3bd1e089-480b-0410-8dfb-8563597acbee
COMP: Update ITKv4 to fix Gcc 4.2.1 Apple compiler seg fault

Following r22163, ITKv4 hash tag has been updated to point to the release
branch. This introduced the regression documented in [1]

This commit fixes the problem by including the ITK commit f49a7db7. For
sake of completeness, the corresponding message is also reported below.

[1] https://itk.icts.uiowa.edu/jira/browse/ITK-3172


// --------------------
BUG: Disable aligned attribute to fix Apple GCC 4.2.1 seg
 fault

Commit 2f96c578 fixed the configure test checking if aligned
attributes were supported by the compiler. Then commit e906441e
disabled the test for Gcc 4.1 to prevent a similar error.

This commit ensures that the configure test also excludes Apple
Gcc 4.2.1 (without llvm support) by forcing the configure test to
be in "Debug" mode.

When this issue was first encountered by Brad, the problem was occurring
in Debug mode and he narrowed it down to the block of code in the try_compile
and tried to use it as a detector. Slicer appears to have encountered the
same issue in release mode, but the bug detector only detects it in Debug
mode.

Co-authored-by: Bradley Lowekamp <blowekamp@mail.nih.gov>
// --------------------

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22171 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Update OpenIGTLinkIF GIT_TAG to fix issues #3224 and #3225

Issue 3224: std::list increment assertion failure on Windows
Issue 3225: vtkMRMLIGTLConnectorNode: bug in unregistering incoming MRML node

See https://github.com/openigtlink/OpenIGTLinkIF/compare/f9b65b1ffd2992862025f3c6ec5fe30e6f5dd395...533af932a1c899a0872c35b41113075f7da1ac1b

Co-authored-by: Isaiah Norton <inorton@bwh.harvard.edu>
Co-authored-by: Adam Rankin <rankin@cs.queensu.ca>

From: Junichi Tokuda <tokuda@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22172 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: warning was displayed via vtkErrorMacro

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22173 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: warning message was incorrectly labeled as error

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22174 3bd1e089-480b-0410-8dfb-8563597acbee
ENH: Add toolbar for the Extensions Manager and Error log

Fixes #3151

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

From: Chrystel Juan <chrystel.juan@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22175 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Turn off projections when annotations are deleted

Projections of annotations were not deleted with annotation.
This fix ensure the widget representing an annotation's projection is
deleted when the corresponding annotation is deleted.

Partially fixes #3214

From: Laurent Chauvin <lchauvin@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22176 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Ensure projections do not appear as selectable

Projections are not selectable and shouldn't be, however they
were displayed as if they were selectable, so it could be confusing
for the user. This fix ensure projections are properly displayed to
not look like selectable.

Fixes #3222

From: Laurent Chauvin <lchauvin@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22177 3bd1e089-480b-0410-8dfb-8563597acbee
COMP: External_SimpleITK - Fix unused CMake variable warnings

CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_EXAMPLES
    PYTHON_FRAMEWORKS

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22178 3bd1e089-480b-0410-8dfb-8563597acbee
COMP: Simplify passing of SimpleITK external project arguments

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22179 3bd1e089-480b-0410-8dfb-8563597acbee
COMP: Fix unused variable warnings

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22180 3bd1e089-480b-0410-8dfb-8563597acbee
COMP: In test driver on windows, log VTK messages on standard output

Before this commit, VTK message were logged into a GUI windows
preventing them from being captured and interpreted by the testing
harness.

Fixes #3221

Co-authored-by: Csaba Pinter <pinter@cs.queensu.ca>

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22181 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Turn off projections when annotations are not visible

Projections of annotations were not "hidden" with annotation.

This fix ensure the widget representing an annotation's projection
is "hidden" when an annotation visibility is turned off.

This commit is a follow-up of r22176 ensuring projections are deleted
when an annotation is deleted.

Fixes #3214

From: Laurent Chauvin <lchauvin@bwh.harvard.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22182 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Fix vtkMRMLCameraDisplayableManagerTest1

Following r22159 fixing issue #1798, the "useDepthPeeling" view node
property has been introduced, this commit updates the mrml input file
used by the test with this new property.

Related to #1798

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22183 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Fix TranslatorPlayer tests to account for ctkSpinBox renaming

Commit r22128 updated CTK to propagate renaming of ctkSpinBox
into ctkDoubleSpinBox, this commit also fixes the test that were
using ctkSpinBox.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22184 3bd1e089-480b-0410-8dfb-8563597acbee
COMP: Ensure external module can directly find Slicer

Following commit r22063, extensions bundled using Slicer_EXTENSION_SOURCE_DIRS
didn't have to use the "if(NOT Slicer_SOURCE_DIR)" safeguard.

This commit move inclusion of external modules from the CLI, Loadable
and Scripted sub-directories into a single "Modules/Remote" folder
included after Slicer_DIR so that external module can also directly call
"find_package(Slicer)"

Thanks to Brad Lowekamp for reporting the issue.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22185 3bd1e089-480b-0410-8dfb-8563597acbee
STYLE: Use static member variables for reference roles and attribute name

Issue #2727

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22186 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Copy NodeReferenceMRMLAttributeNames in vtkMRMLNode::Copy()

Issue #2727

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22187 3bd1e089-480b-0410-8dfb-8563597acbee
ENH: Add support for node reference templates

In vtkMRMLSelectionNode, the exact name of the reference roles of a unit is
not known until the unit is set and observed. (it's a dynamic number of
unit reference roles). By using a special key '/' in the reference role
(e.g. "unit/"), it is possible to have multiple reference roles
(e.g. "unit/length", "unit/time"...).
Issue #2727

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22188 3bd1e089-480b-0410-8dfb-8563597acbee