change all to return string