Need to re-initialize the va_list between calling vsnprintf and vprintf
on Linux otherwise we get interestingly corrupted output.
Remove set-but-unused variables as indicated by GCC.
Remove a block of disabled code as there were some unused variables that
GCC was complaining about.
Changed assert macro to "use" the condition so that we don't have unused
variable warnings happening in optimized builds.
Ensure that we check the return value of posix_memalign.
VM_ASSERT_NOTRACE should be properly guarded.
First, ensure that we re-create the va_list for all code paths, not just
the one where we call vprintf. Second, ensure that we test the return
value from fread.
Add an OPT option, to optimize the build. Right now you can do "make
OPT={0,1,2,3,s}", though in the end this may just be made into an on/off
switch.