On Sat, Dec 7, 2013 at 2:43 PM, johnjbarton <notifications@github.com>wrote:

> In test/unit/runtime/System.js:
>
> > -    var options = {referer: {name: importer}};
> > -    var normalized = System.normalize('./IdentifierToken', options);
> > -    assert.equal(normalized, 'src/syntax/IdentifierToken');
> > -    var resolved = System.resolve(normalized);
> > -    assert.equal(resolved,
> > -                 'http://example.org/a/src/syntax/IdentifierToken.js');
> > +  test('System.locate', function() {
> > +    var load = {
> > +      metadata: {
> > +        baseURL: 'http://example.org/a/'
> > +      }
> > +    }
> > +    load.name = '@abc/def';
> > +    assert.equal(System.locate(load), '@abc/def');
> > +    load.name = './abc/def';
> > +    assert.equal(System.locate(load), 'http://example.org/a/abc/def.js');
>
> You are describing the operation of System.normalize() but here we are
> testing System.locate() which should only be called with normalized (and
> not relative) module names.
>
I'm not sure what this refers to? Github for code reviews is really not
very good.

I agree that this snippet is all about localize and it looks fine to me.


-- 
erik