Good call.


On Thu, May 2, 2013 at 5:33 PM, Jeff Kolesky <notifications@github.com>wrote:

> In
> kiji-mapreduce/src/main/java/org/kiji/mapreduce/framework/SmartKijiTableInputFormat.java:
>
> > +                                            + "post hash start key must be incrementable",
> > +                                            postHashStartKeyEncoded, KIJI_POST_HASH_START_KEY));
> > +      }
> > +
> > +      // In cases were the end key does not equal the postHashStartKey, we'll want to use
> > +      // the said prefix + 1.
> > +      byte[] postHashEndKey = postHashStartKey.clone();
> > +      incrementKey(postHashEndKey, 1);
> > +
> > +      final KijiURI inputTableURI = KijiURI.newBuilder(
> > +                                      conf.get(KijiConfKeys.KIJI_INPUT_TABLE_URI)).build();
> > +      final Kiji kiji = Kiji.Factory.open(inputTableURI, conf);
> > +      try {
> > +        final KijiTable table = kiji.openTable(inputTableURI.getTable());
> > +        RowKeyFormat2 rowKeyFormat2 = (RowKeyFormat2) table.getLayout().getDesc().
> getKeysFormat();
> > +        int hashSize = rowKeyFormat2.getSalt().getHashSize();
>
> According to the Layout.avdl, the salt is nullable, so you should check
> for it being null. And in theory, a null salt should make this class just
> call its parent class' getSplits method.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/opower/kiji-mapreduce/pull/4/files#r4067320>
> .
>