finished add role.