Unreviewed. [Chromium] Rebaseline fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html for Chromium-Mac and Chromium-Win
after changes of https://bugs.webkit.org/show_bug.cgi?id=95285

* platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt:
* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt:
* platform/chromium/TestExpectations:

git-svn-id: svn://svn.chromium.org/blink/trunk@127105 bbb929c8-8fbe-4397-9dbb-9b2b20218538
[V8] ScriptController::matchesCurrentContext duplicates code from ScriptController::currentWorldContext
https://bugs.webkit.org/show_bug.cgi?id=95156

Reviewed by Eric Seidel.

matchesCurrentContext duplicated code from currentWorldContext in order
to avoid creating a new v8::Local handle in the (common) case that
we're already in the right context. This patch just exposes an accessor
for the underlying handle so that the bindings code can do this work
itself.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateToV8Converters):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::wrapSlow):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::unsafeHandleToCurrentWorldContext):
(WebCore):
(WebCore::ScriptController::currentWorldContext):
* bindings/v8/ScriptController.h:
(ScriptController):
* bindings/v8/V8DOMWindowShell.h:
(WebCore::V8DOMWindowShell::context):


git-svn-id: svn://svn.chromium.org/blink/trunk@127106 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Layout Test fast/repaint/japanese-rl-selection-repaint-in-regions.html is failing after r126304
https://bugs.webkit.org/show_bug.cgi?id=94730

Patch by Andrei Bucur <abucur@adobe.com> on 2012-08-29
Reviewed by Dimitri Glazkov.

Re-enable the japanese-rl-selection-repaint-in-regions.html test for Chromium after the fix was deployed.

* platform/chromium/TestExpectations:

git-svn-id: svn://svn.chromium.org/blink/trunk@127107 bbb929c8-8fbe-4397-9dbb-9b2b20218538
AuthorShadowDOM support for textarea element.
https://bugs.webkit.org/show_bug.cgi?id=91485

Reviewed by Dimitri Glazkov.

Source/WebCore:

We add AuthorShadowDOM support for textarea element.

Unlike other replaced elements (e.g. meter, progress, img), we do not need to add
extra RenderBlock when we add AuthorShadowDOM. However, since inner element will not have
renderer when AuthorShadowDOM does not have any shadow insertion point, we have to check
the existence of the renderer of inner element.

Tests: fast/dom/shadow/shadowdom-for-textarea-with-attribute.html
       fast/dom/shadow/shadowdom-for-textarea-with-placeholder.html
       fast/dom/shadow/shadowdom-for-textarea-with-style.html
       fast/dom/shadow/shadowdom-for-textarea.html

* dom/ShadowRoot.cpp:
(WebCore::allowsAuthorShadowRoot): Needs allow textarea to have AuthorShadowRoot.
* rendering/RenderTextControl.cpp: When AuthorShadowDOM does not have any insertion point,
innerTextElement() will not have any renderer. We have to tweak these renderers not to be crashed.
(WebCore::RenderTextControl::textBlockWidth):
(WebCore::RenderTextControl::updateFromElement):
(WebCore::RenderTextControl::computeLogicalHeight):
(WebCore::RenderTextControl::hitInnerTextElement):
(WebCore::RenderTextControl::computePreferredLogicalWidths):

LayoutTests:

We have the following tests.
(1) having only <shadow> insertion point.
(2) not having <shadow> insertion point.
(3) having <shadow> and <content> insertion point.
(4) with rows/cols attribute
(5) with placeholder attribute

* fast/dom/shadow/shadow-disable-expected.txt:
* fast/dom/shadow/shadow-disable.html:
* fast/dom/shadow/shadowdom-for-textarea-complex-shadow-expected.html:
* fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html:
* fast/dom/shadow/shadowdom-for-textarea-expected.html: Added.
* fast/dom/shadow/shadowdom-for-textarea-only-shadow-expected.html:
* fast/dom/shadow/shadowdom-for-textarea-only-shadow.html:
* fast/dom/shadow/shadowdom-for-textarea-with-attribute-expected.html: Copied from LayoutTests/fast/dom/shadow/shadowdom-for-textarea-only-shadow-expected.html.
* fast/dom/shadow/shadowdom-for-textarea-with-attribute.html: Copied from LayoutTests/fast/dom/shadow/shadowdom-for-textarea-only-shadow.html.
* fast/dom/shadow/shadowdom-for-textarea-with-placeholder-expected.html: Added.
* fast/dom/shadow/shadowdom-for-textarea-with-placeholder.html: Added.
* fast/dom/shadow/shadowdom-for-textarea-with-style-expected.html: Added.
* fast/dom/shadow/shadowdom-for-textarea-with-style.html: Copied from LayoutTests/fast/dom/shadow/shadowdom-for-textarea-only-shadow.html.
* fast/dom/shadow/shadowdom-for-textarea-without-shadow.html:
* fast/dom/shadow/shadowdom-for-textarea.html: Added.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:


git-svn-id: svn://svn.chromium.org/blink/trunk@127108 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Unreviewed GTK gardening.

Adding failure expectations for media/video-controls-captions.html
and svg/custom/clamped-masking-clipping.svg, the tests have been failing
since introduced in r127035 and r126993, respectively.

Also adding a flakiness expectation for
fast/layers/scroll-no-visible-content-but-visible-descendant.html.

* platform/gtk/TestExpectations:


git-svn-id: svn://svn.chromium.org/blink/trunk@127109 bbb929c8-8fbe-4397-9dbb-9b2b20218538
[Qt] Unreviewed gardening, skip new failing tests.

* platform/qt/Skipped:

git-svn-id: svn://svn.chromium.org/blink/trunk@127110 bbb929c8-8fbe-4397-9dbb-9b2b20218538
[EFL] Gardening after r127135, r127039
https://bugs.webkit.org/show_bug.cgi?id=95433

Unreviewed gardening.

Gardening of media/video-controls-captions.html and inspector/timeline/timeline-load.html.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-30

* platform/efl/TestExpectations:

git-svn-id: svn://svn.chromium.org/blink/trunk@127111 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Replace uses of WTF::String::operator+= with StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=95416

Reviewed by Benjamin Poulain.

WTF::String::operator+= appears to be a sandtrap for contributors. The
vast majority of the callers are using very inefficient string
patterns. This patch removes the use of operator+= in favor of
StringBuilder. Eventually, I'd like to remove operator+= so that more
code doesn't fall into this trap.

* Modules/websockets/WebSocketHandshake.cpp:
(WebCore::resourceName):
* html/HTMLAnchorElement.cpp:
(WebCore::appendServerMapMousePosition):
(WebCore::HTMLAnchorElement::handleClick):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::font):
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::addHTTPHeaderField):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::nameForLayer):
* rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::nodePosition):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setContent):


git-svn-id: svn://svn.chromium.org/blink/trunk@127112 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Build fix for WinCE after r126974.

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::reportMemoryUsage):

git-svn-id: svn://svn.chromium.org/blink/trunk@127113 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Build fix for COMPILER(MSVC) && !CPU(X86) after r127001.

* wtf/MathExtras.h:
(lrint): Added additional parentheses to silence compiler warning.

git-svn-id: svn://svn.chromium.org/blink/trunk@127114 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Web Inspector: move GeneratedImage members into its own cpp file
https://bugs.webkit.org/show_bug.cgi?id=95351

Reviewed by Yury Semikhatsky.

It is trivial patch. The methods of GeneratedImage were in GeneratorGeneratedImage.cpp file.
It was Ok when it was a single method.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/GeneratedImage.cpp: Added.
(WebCore):
(WebCore::GeneratedImage::computeIntrinsicDimensions):
(WebCore::GeneratedImage::reportMemoryUsage):
* platform/graphics/GeneratorGeneratedImage.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@127115 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Web Inspector: [Sources] Invisible right sidebar issue
https://bugs.webkit.org/show_bug.cgi?id=94924

Reviewed by Pavel Feldman.

Debugger sidebar resizer is now hidden when sidebar is hidden.
Debugger sidebar show button is moved to the upper right corner in this case.

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._showDebuggerSidebar):
(WebInspector.ScriptsPanel.prototype.set _hideDebuggerSidebar):
* inspector/front-end/scriptsPanel.css:
(button.status-bar-item.scripts-debugger-show-hide-button):
(button.status-bar-item.scripts-debugger-show-hide-button:active):
(button.status-bar-item.scripts-debugger-show-hide-button.toggled-shown):
(button.status-bar-item.scripts-debugger-show-hide-button.toggled-shown:active):
(button.status-bar-item.scripts-debugger-show-hide-button.toggled-hidden):
(button.status-bar-item.scripts-debugger-show-hide-button.toggled-hidden:active):


git-svn-id: svn://svn.chromium.org/blink/trunk@127116 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Heap-use-after-free in WebCore::ElementV8Internal::onclickAttrGetter
https://bugs.webkit.org/show_bug.cgi?id=94440

Reviewed by Adam Barth.

The problem appears due to onerror callback which resets onclick attribute.
As a part of changing onclick attribute value, previous event listener
gets deref which led to its destruction and hence use-after-free.
Refing it in ::getListenerObject helps to prevent this unfortunate scenario.

Source/WebCore:

Test: fast/events/set-attribute-listener-window-onerror-crash.html

* bindings/v8/V8AbstractEventListener.h:
(WebCore::V8AbstractEventListener::getListenerObject):

LayoutTests:

* fast/events/set-attribute-listener-window-onerror-crash-expected.txt: Added.
* fast/events/set-attribute-listener-window-onerror-crash.html: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@127117 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Fix compile warning when enable tiled backing store
https://bugs.webkit.org/show_bug.cgi?id=95422

Patch by Kangil Han <kangil.han@samsung.com> on 2012-08-30
Reviewed by Kentaro Hara.

Fixed compile warning messages when enabled tiled backing store.
In case of TiledBackingStore, it was first thought about static_cast<unsigned>.
However, if minus value is assigned to the comparison, it would be critical.
So, it was modified as using int value in tiled coordinate calculation.

* page/Frame.cpp:
(WebCore::Frame::tiledBackingStorePaintEnd): comparison between signed and unsigned integer expressions [-Wsign-compare]
* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::invalidate): comparison between signed and unsigned integer expressions [-Wsign-compare]
(WebCore::TiledBackingStore::paint): comparison between signed and unsigned integer expressions [-Wsign-compare]
(WebCore::TiledBackingStore::coverageRatio): comparison between signed and unsigned integer expressions [-Wsign-compare]
(WebCore::TiledBackingStore::createTiles): comparison between signed and unsigned integer expressions [-Wsign-compare]
* platform/graphics/cairo/GLContext.cpp:
(WebCore::GLContext::createOffscreenContext): no return statement in function returning non-void [-Wreturn-type]

git-svn-id: svn://svn.chromium.org/blink/trunk@127118 bbb929c8-8fbe-4397-9dbb-9b2b20218538
[EFL] Gardening for fast/forms/range/thumbslider-no-parent-slider.html after r126864
https://bugs.webkit.org/show_bug.cgi?id=95437

Unreviewed, gardening.

Slider thumb can be displayed without parent slider after r126864.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-08-30

* platform/efl/TestExpectations:
* platform/efl/fast/forms/range/thumbslider-no-parent-slider-expected.png: Added.
* platform/efl/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@127119 bbb929c8-8fbe-4397-9dbb-9b2b20218538
[Qt] REGRESSION(r122175): fast/loader/document-destruction-within-unload.html makes the following test assert
https://bugs.webkit.org/show_bug.cgi?id=95441

Unreviewed gardening.

* platform/qt/Skipped: Skip fast/loader/document-destruction-within-unload.html to paint the bot green.

git-svn-id: svn://svn.chromium.org/blink/trunk@127120 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Use ASCIILiteral for DEFINE_STATIC_LOCAL string
https://bugs.webkit.org/show_bug.cgi?id=95420

Reviewed by Benjamin Poulain.

As recommended by http://trac.webkit.org/wiki/EfficientStrings,
WebKit needs to use ASCIILiteral for the string of DEFINE_STATIC_LOCAL.

Source/WebKit/blackberry:

* Api/WebSettings.cpp:
(WebKit):

Source/WebKit/gtk:

* webkit/webkitwebsettings.cpp:
(webkitPlatform):
(webkitOSVersion):


git-svn-id: svn://svn.chromium.org/blink/trunk@127121 bbb929c8-8fbe-4397-9dbb-9b2b20218538
[NRWT] Add support for recognizing arbitrary process names in crash lines
https://bugs.webkit.org/show_bug.cgi?id=95435

Reviewed by Adam Barth.

When running layout tests in the chromium port using the content shell,
we want to be able to report sub-process crashes as well.

* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver._check_for_driver_crash):
* Scripts/webkitpy/layout_tests/port/driver_unittest.py:
(DriverTest.test_check_for_driver_crash):


git-svn-id: svn://svn.chromium.org/blink/trunk@127122 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Cache and share parsed imported stylesheets
https://bugs.webkit.org/show_bug.cgi?id=95219

Reviewed by Andreas Kling.

We currently cache and share parsed data structures of stylesheets loaded with <link>. We should do
the same with stylesheets loaded using @import rules as they are also fairly common.
        
This patch adds support for caching and sharing stylesheets loaded using @import rules. Only leaf
stylesheets (that don't have @import rules themselves) can be cached for now.

* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::reattachStyleSheetContents):
(WebCore):
* css/CSSImportRule.h:
(CSSImportRule):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::willMutateRules):
(WebCore::CSSStyleSheet::reattachCSSOMWrappers):
* css/CSSStyleSheet.h:
(CSSStyleSheet):
* css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::setCSSStyleSheet):
(WebCore::StyleRuleImport::reattachStyleSheetContents):
(WebCore):
* css/StyleRuleImport.h:
(StyleRuleImport):
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::saveParsedStyleSheet):



git-svn-id: svn://svn.chromium.org/blink/trunk@127123 bbb929c8-8fbe-4397-9dbb-9b2b20218538
1.9.90 drops symbols, breaking compatibility
https://bugs.webkit.org/show_bug.cgi?id=93477

Patch by Xan Lopez <xlopez@igalia.com> on 2012-08-30
Reviewed by Martin Robinson.

Add a bunch of compatibility methods to the GObject DOM bindings
to cope with recent renames.

* bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_html_element_get_class_list):
(webkit_dom_element_get_webkit_region_overflow):
(webkit_dom_webkit_named_flow_get_content_nodes):
(webkit_dom_webkit_named_flow_get_regions_by_content_node):
* bindings/gobject/WebKitDOMCustom.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@127124 bbb929c8-8fbe-4397-9dbb-9b2b20218538