Setting defaults in the plugin JS is okay as long as they are easy to override without changing the plugin JS (e.g., CSS class overrides, data-wet-boew overrides, config file overrides, etc).

Paul Jackson
Web Project Officer | Agent de projet Web
Web Standards Office | Bureau des normes Web
Chief Information Officer Branch | Direction du dirigeant principal de l'information
Treasury Board of Canada, Secretariat | Secrétariat du Conseil du Trésor du Canada
Ottawa, Canada K1A 0R5
Paul.Jackson@tbs-sct.gc.ca
Telephone | Téléphone 613-960-1032 / Facsimile | Télécopieur 613-957-8020 / Teletypewriter | Téléimprimeur 613-957-9090
Government of Canada | Gouvernement du Canada

From: Nick Schonning [mailto:notifications@github.com]
Sent: Friday, March 15, 2013 04:31 PM Eastern Standard Time
To: wet-boew/wet-boew <wet-boew@noreply.github.com>
Cc: Jackson, Paul
Subject: Re: [wet-boew] Feature geomap (#1539)


In src/js/workers/geomap.js:

> +
> +                     return $ref;
> +             },
> +
> +             /*
> +              *      Set the default basemap
> +              */
> +             setDefaultBaseMap: function(opts) {
> +                     if(opts.debug) {
> +                             window.console.log(_pe.fn.geomap.getLocalization('basemapDefault'));
> +                     }
> +
> +                     // Add the Canada Transportation Base Map (CBMT)
> +                     map.addLayer(new window.OpenLayers.Layer.WMS(
> +                             "CBMT",
> +                             "http://geogratis.gc.ca/maps/CBMT",


@pjackson<https://github.com/pjackson> should we be including a default service like this even if it is a gc?

—
Reply to this email directly or view it on GitHub<https://github.com/wet-boew/wet-boew/pull/1539/files#r3398797>.