tests: expose bug#14991 (relates to 'distcheck')

* t/distcheck-no-prefix-or-srcdir-override.sh: New, expose the bug.
* t/list-of-tests.mk (handwritten_TESTS, XFAIL_TESTS): Add it.

Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
distcheck: don't allow overriding of --prefix and --srcdir by the user

Not through AM_DISTCHECK_FLAGS, nor through DISTCHECK_FLAGS.  Apparently,
some packages got in the habit of relaying all the options passed to the
original ./configure invocation through to the configure invocations
in "make distcheck".  This was causing problems, because it also passed
through the original --srcdir and --prefix options.

Fixes: expose bug#14991 (relates to 'distcheck')

* lib/am/distdir.am (distcheck): Pass the hard-coded --srcdir and
--prefix options *after* both the developer-defined options in
$(AM_DISTCHECK_FLAGS) and the user-defined options in $(DISTCHECK_FLAGS).
* t/list-of-tests.mk (XFAIL_TESTS): Remove the now-passing test
'distcheck-no-destdist-or-srcdir-override.sh'.
* doc/automake.texi (Checking the Distribution): Update.
* NEWS: Likewise.

Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
install-sh: assume 'dirname' is available and working correctly

Really, we no longer care about hosts so outdated/broken to miss
fundamental utilities like basename or dirname.

* lib/install.sh: Adjust.
* NEWS, THANKS: Update.

Suggested-by: Philipp A. Hartmann <philipp.hartmann@offis.de>
Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
install-sh: assume ${var:-value} works as expected

The Autoconf manual says it is OK these days.

* lib/install.sh: Adjust.
* NEWS: Update.

Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
install-sh: assume that "set -f" and "set +f" work...

... and disable/enable shell globbing, respectively.  This is
mandated by POSIX, and supported even by Solaris 9 /bin/sh (one
of the most braindead shells we still support).

* lib/install.sh: Adjust.
* NEWS: Update.

Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
cosmetics: untabify the install-sh script

* lib/install-sh: Here, plus a couple of related formatting tweaks.

Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
tests: avoid use of intervals to capitalize letters

It was causing spurious failures with with Solaris 8 'tr'.
See automake bug#14891.

* t/test-extensions.sh: Adjust.

Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
automake: account for perl hash order randomization

Try to explicitly order the keys of some perl hashes when looping
on them to do sanity/correctness checks and possibly display warning
messages; this should ensure a more reproducible output.  Not really
a big deal, but I prefer to keep the order of such output reproducible
if possible.

Issue revealed by spurious testsuite failures with perl 5.18, as
reported in automake bug#14891.  See also:
<http://search.cpan.org/dist/perl-5.18.0/pod/perldelta.pod#Hash_randomization>
<http://onionstand.blogspot.ie/2012/12/are-you-relying-on-hash-keys-being.html>

* lib/Automake/Variable.pm (variables): Explicitly order the values of
the returned Automake::Variable instances.
(variables_dump): Simplify, using the knowledge that 'variables()' now
sorts its output.
* t/preproc-errmsg.sh: Adjust.

Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
Merge branches 'fix-pr14991' and 'fix-pr14891' into micro

* fix-pr14991:
  distcheck: don't allow overriding of --prefix and --srcdir by the user
  tests: expose bug#14991 (relates to 'distcheck')

* fix-pr14891:
  automake: account for perl hash order randomization
  tests: avoid use of intervals to capitalize letters
cosmetics: fix typo in a user-facing message in tests

* t/lex-header.sh: A "skip" message in this test, precisely.

Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
Merge branch 'micro' into minor

* micro:
  cosmetics: fix typo in a user-facing message in tests
  automake: account for perl hash order randomization
  tests: avoid use of intervals to capitalize letters
  distcheck: don't allow overriding of --prefix and --srcdir by the user
  tests: expose bug#14991 (relates to 'distcheck')
Merge branch 'modernize-install-sh' into minor

* modernize-install-sh:
  cosmetics: untabify the install-sh script
  install-sh: assume that "set -f" and "set +f" work...
  install-sh: assume ${var:-value} works as expected
  install-sh: assume 'dirname' is available and working correctly
Merge branch 'minor'

* minor:
  cosmetics: fix typo in a user-facing message in tests
  automake: account for perl hash order randomization
  tests: avoid use of intervals to capitalize letters
  cosmetics: untabify the install-sh script
  install-sh: assume that "set -f" and "set +f" work...
  install-sh: assume ${var:-value} works as expected
  install-sh: assume 'dirname' is available and working correctly
  distcheck: don't allow overriding of --prefix and --srcdir by the user
  tests: expose bug#14991 (relates to 'distcheck')
TAP driver: cosmetic fixes

* lib/tap-driver.sh: Quote 'like this', not `like this'.  Remove an
obsolete FIXME.  Correctly mark another comment as a TODO rather
than as a FIXME.

Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
sync: update INSTALL, config.guess and config.sub from upstream

Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
maintainer: am-ft: add option to cater to clock skews

* maintainer/am-ft: Add option '-S', giving a number of seconds to sleep
after copying the tarball to the remote system and before unpacking,
building and testing it.  This is to cater to situations where the clock
of the remote system is skewed (in the past) w.r.t. the clock the local
system the tarball has been built on.

Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
tests: remove too-brittle test tap-realtime.sh

* t/tap-realtime.sh: Delete.  It has always been brittle, but now
it's also causing spurious failures when mawk is used as the awk
implementation in tap-driver.sh (see bug#14601).
* t/list-of-tests.mk: Adjust.

Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
tests: make install-info-dir.sh print more debugging info

With the hope that this will shed more light on bug#14601

Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
HACKING: minor clarification

Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
release: stable micro release 1.14.1

* configure.ac (AC_INIT): Bump version number to 1.14.1.
* m4/amversion.m4: Likewise (auto-updated by "make bootstrap").

Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>