Verify is thread-fatal, while fassert is process-fatal. Is the process
compromised after CHECK failures in S2? If so, fassert.
On Jun 5, 2013 1:37 PM, "Hari Khalsa" <notifications@github.com> wrote:

> In src/third_party/s2/base/logging.h:
>
> >
> >  // Always-on checking
> > -#define CHECK(x)	if(x){}else LogMessageFatal(__FILE__, __LINE__).stream() << "Check failed: " #x
> > +#define CHECK(x)	if(x){}else VLOG(2) << __FILE__ << ":" << __LINE__ << ": Check failed: " #x
>
> I agree. Thanks for looking into this. Should be good to pull once that
> change is made.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mongodb/mongo/pull/430/files#r4550584>
> .
>