sounds like a good idea. presumed the implementation could be refactored to
be nicer. agree with scope suggestion.



On 8 November 2013 14:43, Jon Lemmon <notifications@github.com> wrote:

> In app/views/users/show.html.haml:
>
> > @@ -6,3 +6,10 @@
> >        %h1= @user.name
> >        %p.username= "@" + @user.username
> >        %p.email= mail_to @user.email
> > +
> > +      -if @groups
>
> When I look at this I don't understand what @groups is without looking at
> the controller. In general I think we wanna stay away from defining extra
> instance variables in the controller. Instead I think we should add a scope
> to user, e.g. @user.public_goups
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/loomio/loomio/pull/1155/files#r7517121>
> .
>