sounds good, ideally I want to indent them all and do `class << self` but
that would just blow up this pull request unnecessarily


On Thu, May 23, 2013 at 3:07 PM, Felix Clack <notifications@github.com>wrote:

> In lib/parallel_tests/grouper.rb:
>
> > @@ -40,8 +40,6 @@ def self.by_steps(tests, num_groups, options)
> >        in_even_groups_by_size(features_with_steps, num_groups)
> >      end
> >
> > -    private
>
> Using private is this way with class methods doesn't work and is
> effectively a comment, how about I add a fix to actually make them class
> methods using the private_class_method keyword.
>
> It looks like everything but self.by_steps should be private as that is
> the only method that gets called outside this class. What do you think?
>
> eg.
>
> def self.build_features_with_steps
>   ...
> end
> private_class_method :build_features_with_steps
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/grosser/parallel_tests/pull/222/files#r4371766>
> .
>