In generally, you should be very careful about modifying the behavior of
existing functions. The general rule is that if it's documented, then you
shouldn't change it without a deprecation strategy. Since we've only just
recently had any real documentation, we have a bit of free reign in that
regard :)


On Mon, Jul 1, 2013 at 2:29 PM, Nick McLaughlin <notifications@github.com>wrote:

> In src/wymeditor/editor/base.js:
>
> >  */
> > -WYMeditor.editor.prototype.switchTo = function (node, sType) {
> > +WYMeditor.editor.prototype.switchTo = function (node, sType, keepAttrs) {
>
> That's fine. I just thought it was good practice not to modify the
> existing behavior of the function everywhere it is used.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/wymeditor/wymeditor/pull/412/files#r4968551>
> .
>



-- 
*Wes Winham, Product Development*
PolicyStat, LLC | mobile: 405.320.9379 | desk: 317.644.1296 x1105
schedule: http://meetme.so/wesw