Zero makes sense.


2013/5/13 Bernerd Schaefer <notifications@github.com>

> In storage/metric/leveldb.go:
>
> > -		return fmt.Errorf("Could not compact curation remarks: %s", err)
> > +func (l *LevelDBMetricPersistence) CompactKeyspaces() {
> > +	l.CurationRemarks.CompactKeyspace()
> > +	l.fingerprintToMetrics.CompactKeyspace()
> > +	l.labelNameToFingerprints.CompactKeyspace()
> > +	l.labelSetToFingerprints.CompactKeyspace()
> > +	l.MetricHighWatermarks.CompactKeyspace()
> > +	l.metricMembershipIndex.CompactKeyspace()
> > +	l.MetricSamples.CompactKeyspace()
> > +}
> > +
> > +func (l *LevelDBMetricPersistence) ApproximateSizes() (total uint64, err error) {
> > +	size := uint64(0)
> > +
> > +	if size, err = l.CurationRemarks.ApproximateSize(); err != nil {
> > +		return total, err
>
> I'm not sure -- I guess it depends if the aggregate size can be acted on
> even in the presence of a failure in one database. If so, I'd say we should
> return the total size and either an aggregated error or the last non-nil
> error. If not, we should probably change the error returns to return 0,
> err to signal that fact.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/prometheus/prometheus/pull/243/files#r4190891>
> .
>