installer: Fix EFI boot entry removal

Previously removing EFI entries during a reinstall failed due to an
incorrect call to efibootmgr.
This patch adds a wrapper around efibootmgr and provides an API to add
an remove EFI boot entries.

This shall prevent incorrect function calls to efibootmgr.
The new API is now also used in the legacy (installer) code.

Change-Id: I761ac056f4a168eefbc49319c0ff66239a9ded38
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=950553
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
remove existing efi entries when uninstall rhev-h in efi boot

Change-Id: Ib1f63a9a0fdb9fb1c6211ebd8247459ddcda46db
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=950893
Signed-off-by: hadong <hadong0720@gmail.com>
bump rawhide to 21

fedora branch to F20 done today

Change-Id: I45b59ea3ed827baa9f9a1298b678be5f53d2e65c
Signed-off-by: Mike Burns <mburns@redhat.com>
network_page:fix always prompt "no changes, nothing to do." issue

Change-Id: Ib0a97d1d399c72258e85f47c7b9f636aa2a7ff60
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1003231
Signed-off-by: hadong <hadong0720@gmail.com>
Fix [Error 2]No such file or directory issue when setting NFSv4 Domain.

Change-Id: I6dded758e8dc6a61c3af1ec4445ff276c61fa5eb
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998392
Signed-off-by: hadong <hadong0720@gmail.com>
add --shell option to edit-node

Change-Id: Ia71b39a9e90f91a84cbbdd676a58ad254a28582a
Signed-off-by: Joey Boggs <jboggs@redhat.com>
Fix EFI boot entry shown "fedora" issue

Actually the EFI boot entry should show "oVirt Node Hypervisor",not
"fedora" value.
Also this patch fixed using wrong loader_filename issue.
(For fedora, the loader_filename should be "grubx64.efi."
 For rhel, the loader_filename should be "grub.efi")

Change-Id: Ia326f049cbea64e646a974105f265a22c45f315f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1004120
Signed-off-by: hadong <hadong0720@gmail.com>
add wait code after the call of fuction subprocess_closefds.

Now in ovirt-node, we has the fail possible to get the output
the call of subprocess_closefds, because of not waiting for
the complete of the command.
This patch is to avoid the problem.

Change-Id: I3b5a7c41c5e6809d148bda37f3fb1a75ed3fd4dd
Signed-off-by: boh.ricky <boh.ricky@gmail.com>
don't remove hdparm

it's needed by tuned

Change-Id: I52ab16a49537fbe36bd35778285574e8f7577913
Bug-Id:  https://bugzilla.redhat.com/1001004
Signed-off-by: Mike Burns <mburns@redhat.com>
add /usr/share/snmp/mibs to rwtab
rhbz#994435

Change-Id: If9cc69dcbb82349fa93d4ba0ca8c32f7a9c305f9
Signed-off-by: Joey Boggs <jboggs@redhat.com>
Break out kdump changes into defaults.py and kdump_page

Move the logic for the kdump SSH key URL into their its own
commit so it's not all lumped in with autoinstall changes.

Change-Id: I07eb09f6ac75d9198b934d5023b73adf96da89a6
Signed-off-by: Ryan Barry <rbarry@redhat.com>
Fix sys.stdin.encoding return None issue

when using "check_output" of process.py in bash script,
sys.stdin.encoding return None, not "utf-8", then
it will throw "TypeError: unicode() argument 2 must be string,
not None" error
Now this patch fix it.

Change-Id: Iecb88f68b3abe904e042a843e3e40a8a553adc8d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1005045
Signed-off-by: hadong <hadong0720@gmail.com>
Disabled accept integer as ipv4 "Netmask".

As accepts the integer,the nic will not come up. When switching it back to
the full netmask it works fine.
So now only accept IPv4Address or empty for "Netmask" of ipv4.

Change-Id: I68b20ea199826532626413ed55467d49d61a58cd
Signed-off-by: hadong <hadong0720@gmail.com>
Bug-Url:https://bugzilla.redhat.com/show_bug.cgi?id=990965
firewall: No shell when cmd is a list

Change-Id: I778271bb878f78d3834976b0476b5c8a42c5041f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1007417
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
ui: Add security check to ConfirmedEntry

Previously it was cumbersome to get the effects of incorrect/unsave
passwords on the UI straight. By pulling the password check code into
the ConfirmedEntry widget and adding a Notice field, the whole process
is simpliefied from a "user" perspektive (plugin writer).

Change-Id: I302ec06290d6c1dd26c7b4e8b3c13727ec8b1131
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
installer: Fix password page

Previously the installer accepted an empty password but failed to
complete the installation. This happened due to an incorrect password
check.
Now the password is checked correctly and the user get's feedback about
the different problems.
Additionally the installer only allows the user to carry on when a valid
password is given.

Change-Id: I2daeebd9ae5079d39af1b4f1b7be6eed9a9ce790
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=985275
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
ui: Rework validation and exception handling

Previously the actual widget of a toolkit was responsible to call and
handle the validation stuff. The pros of this approach were that e.g.
handling simple validation errors was easy and could be directly
implemented by the widget. Problems arose with the introduction with
e.g. the ConfirmedEntry (which is a complex ui.Element in the UI
abstraktion layer). With the introduction of these complex ui.Elements
we also wanted - and needed - to pull the validation and exception
handling into the UI abstraction layer. This is necessary because now it
can be controlle din the UI abstraction layer how invalid data shall be
handled.

Change-Id: I4542a2641c6ce6f9f9126db608abca57a4ca453b
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
ui: Adjust some logging messages and comments

Change-Id: Ic11a3888a720b9a0775ac73c18aea5bc4a9daf8b
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
installer: Use button for custom devices

Previously custom devices could be added by selecting a specific entry
in the table. But this became problematic with the parallel validation
changes.
The functionality is now pulled into a button to simplify the code.

Change-Id: I2a1fcf270ca2246d1c4d521f0d54b7e454276ff5
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
urwid: Only show Label if table label is given

This saves on row at runtime, when no label is given.

Change-Id: I25f978a42b78a1e82f46c3a1a8ca2964ab38e631
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>