Right, but `empty()` performs an `isset()` check for you already, so doing it twice is just asking the same question twice :)  

--  
Phil Sturgeon


On Wednesday, 8 May 2013 at 22:01, Ryun S. wrote:

> In system/cms/modules/streams_core/field_types/choice/field.choice.php:
> > @@ -72,7 +72,7 @@ public function form_output($params, $entry_id, $field) > $default_value = (isset($params['custom']['default_value'])) ? $params['custom']['default_value'] : null; > > // If this is a new input, we need to use the default value or go null > - $value = ( ! $entry_id) ? $default_value : $params['value']; > + $value = ( isset($params['value']) and ! empty($params['value'])) ? $params['value'] : $default_value;  
> No prob, I just wasn't sure if the value key was always gonna be here.
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/pyrocms/pyrocms/pull/2730/files#r4147541).
>  
>  
>