You can remove it from your PR or wait for me to merge it and do it myself.


On Mon, Feb 18, 2013 at 6:31 PM, alex <notifications@github.com> wrote:

> In core/app/controllers/spree/locale_controller.rb:
>
> > @@ -10,7 +10,7 @@ def set
> >        else
> >          flash[:error] = t(:locale_not_changed)
> >        end
> > -      redirect_back_or_default(root_path)
> > +      redirect_back_or_default(spree.root_path)
>
> Alright, that makes perfect sense. Is there anything I need to to fix
> this? Do I need to remove this from my PR?
> … <#13cec36c20ee5e26_>
> On Feb 17, 2013, at 11:21 PM, Ryan Bigg wrote: In
> core/app/controllers/spree/locale_controller.rb: > @@ -10,7 +10,7 @@ def
> set > else > flash[:error] = t(:locale_not_changed) > end > -
> redirect_back_or_default(root_path) > +
> redirect_back_or_default(spree.root_path) That wouldn't be a problem
> because the routes that would be used would still be for the Spree engine,
> not the application. It's the routes which define the routing helper
> contexts. — Reply to this email directly or view it on GitHub.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/spree/spree/pull/2577/files#r3044367>.
>
>