Accept ;)
 On Sep 14, 2013 8:01 AM, "Josh Albrecht" <notifications@github.com> wrote:

> In src/main/scala/com/codexica/s3crate/filetree/local/LinuxFileTree.scala:
>
> > @@ -11,6 +33,26 @@ import scala.concurrent.ExecutionContext
> >   * @author Josh Albrecht (joshalbrecht@gmail.com)
> >   */
> >  class LinuxFileTree(baseFolder: File, ec: ExecutionContext) extends LocalFileTree(baseFolder, ec) {
> > +
> > +  private def getPath(file: File): Path = {
> > +    //check for null parameter
>
> Minor style guide from Code Complete and others: it's best to omit
> comments where the comment is a duplication of the code. If the intent of
> the code is not immediately obvious, it's a sign that it should be
> refactored to make it more obvious.
>
> In this case, we can probably safely omit the comment.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/joshalbrecht/s3crate/pull/1/files#r6363964>
> .
>