I addressed all the issues mentioned up to this point in commit 8e5f08a


On Mon, Jul 22, 2013 at 7:08 PM, Piotr Mitros <notifications@github.com>wrote:

> In src/edinsights/core/decorators.py:
>
> > @@ -178,11 +256,24 @@ def cron(run_every, params=None):
> >      '''
> >      def factory(f):
> >          @periodic_task(run_every=run_every, name=f.__name__)
> > -        def run(func=None):
> > -            if func:
> > -                result = optional_parameter_call(func, default_optional_kwargs, params)
> > +        def run(func=None, *args, **kw):
> > +            # if the call originated from the periodic_task decorator
> > +            # func will be None. If the call originated from the rest of
> > +            # the code, func will be the same as f
>
> I like the comment much better than was there before (no comment), but it
> still took a while to understand what this might mean (and I'm only 90%
> sure I got it right). Would it be possible to improve the description of
> what this means? It may make sense to work with Juho, since he doesn't have
> an expert blindspot.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/edx/insights/pull/8/files#r5333398>
> .
>