yeah....
but i was keeping name of function short as previously used , but you are
right ....
i will change that also.... :)

Thanks
Umesh



On Mon, Apr 22, 2013 at 8:39 AM, Stefan van der Walt <
notifications@github.com> wrote:

> In skimage/filter/edges.py:
>
> > +    image : 2-D array
> > +        Image to process.
> > +    mask : 2-D array, optional
> > +        An optional mask to limit the application to a certain area.
> > +        Note that pixels surrounding masked regions are also masked to
> > +        prevent masked regions from affecting the result.
> > +
> > +    Returns
> > +    -------
> > +    output : ndarray
> > +        The Roberts' Cross edge map.
> > +    """
> > +    return np.sqrt(pdroberts(image, mask)**2 + ndroberts(image, mask)**2)
> > +
> > +
> > +def pdroberts(image, mask=None):
>
> I think we should then have a more descriptive name.
> roberts_positive_diagonal, e.g., isn't brilliant, but at least the reader
> knows where it aims to go.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/scikit-image/scikit-image/pull/517/files#r3894276>
> .
>