Dan,

Good call, I'll take a look when I get time and make sure it fails with 
the existing code.
Sorry for all the work, this is my first time contributing to an open 
source project.

Thanks,


Craig Jackson | Software Engineer II

Phone: (320) 762-9390 |
Website: www.DouglasScientific.com



From:   Dan Vanderkam <notifications@github.com>
To:     danvk/dygraphs <dygraphs@noreply.github.com>, 
Cc:     action0jackson <craig.jackson@douglasscientific.com>
Date:   08/29/2013 02:15 PM
Subject:        Re: [dygraphs] Dygraphs pull request for ISSUE-454 (#265)



In auto_tests/tests/to_dom_coords.js:
> @@ -165,3 +165,32 @@ ToDomCoordsTestCase.prototype.testAxisTickSize = 
function() {
>    assertEquals([200, 0], g.toDomCoords(0, 100));
>    assertEquals([500, 386], g.toDomCoords(100, 0));
>  }
> +
> +ToDomCoordsTestCase.prototype.testChartLogarithmic = function() {

I pulled your changes locally and reverted the change to dygraph.js. This 
test still passed. Could you make it a true regression test?
—
Reply to this email directly or view it on GitHub.


The information transmitted in this e-mail is intended only for the person 
or entity to which it is addressed and contains confidential and/or 
privileged material. This material may further be covered under a separate 
nondisclosure agreement. Any review, re-transmission, dissemination or 
other use of, or pursuing of any action in reliance upon this information 
by persons or entities other than the intended recipient is prohibited. If 
you have received this communication in error, please first notify the 
sender immediately and then delete this communication from all data 
storage devices and destroy all hard copies. Please consider the 
environment before printing this email.