Ok here's my feedback. You are making microoptimizations on code that is
not released yet. It is pointless and this code is probably going to be
changed very frequently until a beta.
On Aug 9, 2013 6:55 PM, "kitskub" <notifications@github.com> wrote:

> In api/src/main/java/org/spout/api/protocol/CodecLookupService.java:
>
> >  import java.lang.reflect.Constructor;
> >  import java.lang.reflect.InvocationTargetException;
> >  import java.util.Collection;
> >  import java.util.Collections;
> > -import java.util.Map;
> > -import java.util.concurrent.ConcurrentHashMap;
> > +import java.util.concurrent.atomic.AtomicInteger;
> >
> >  import org.apache.commons.lang3.tuple.Pair;
> >  import org.spout.api.Spout;
>
> Ian tbh most of your comments don't add anything, they're all mean
> remarks that are off topic.
>
> But seriously: while a lot of his changes are style/formatting changes, he
> has submitted a lot of good code. And formatting is NOT bad. If the only
> reason you're commenting is to give NEGATIVE comments (not even feedback,
> just comments) then go away.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/SpoutDev/Spout/pull/2239/files#r5695301>
> .
>