should be (void *) not (void*)
(int), (long), are ok


On Tue, Aug 27, 2013 at 12:56 PM, Roei Tell <notifications@github.com>wrote:

> In heca-all.c:
>
> >      }
> > -}
> > -
> > -static uint32_t get_param_int(const char *name, const char *optarg)
> > -{
> > -    char target[128];
> > -    uint32_t result = 0;
> > -
> > -    get_param(target, name, 128, optarg);
> > -    result = strtoull(target, NULL, 10);
> > -    if (result <= 0 || (result & 0xFFFF) != result) {
> > -        printf("error?\n");
> > -        fprintf(stderr, "Could not get parameter value");
> > -        exit(1);
> > +    if (newhmr->sz == 0 || newhmr->sz % TARGET_PAGE_SIZE != 0) {
>
> How are these equivalent?
> Let newhmr->sz = 6, TARGET_PAGE_SIZE = 3.
> 6 % 3 != 0 ==> False
> 6 & 2 ==> True
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/hecatonchire/qemu-heca/pull/6/files#r6001131>
> .
>