Flurry Screen Saver: style fixes, correct Jamfile
Screen Saver: style fixes
ScreenSaverRunner: Suspend() and Resume() return status_t
ScreenSaver PreviewView code cleanup.

Eliminate Constants.h, set View color and low color black initially

Move AddPreview and Remove Preview to bottom
PreviewView: Add SaverView() method
ScreenSaver: Make sure password window is shown

… before resuming the saver on B_KEY_DOWN in the message filter.

It was assumed before, now we’re actually checking to make sure.
ScreenSaver, small code simplication.

kMsgSaverSelected is the already the invokation message
Screen Saver: fix race condition

Start the screensaver in the window thread instead of the runner
thread so that there is no lock contention for the window lock in
the runner thread when the saver starts.

The view that gets drawn into is assumed to have been prepared before
being passed to the runner thread, and this assumption has been made
true for the screensaver preview and screen_blanker apps.

Eliminate fHasStarted and the corresponding HasStarted() method in
ScreenSaverRunner as they are no longer needed.

Drawing still happens in the runner thread, and still needs to lock
the window thread potentially causing contention, yet, there
is a timeout here so the contention won't freeze the screensaver window,
only delay drawing the screensaver.

Drawing could be moved to the window thread via message passing to avoid
lock contention with the window but this would defeat a big part of the
purpose of having a separate rendering thread.

This fixes #10125 and #4260