completed impl in my view