should commit changes properly