Remove uses of instance['instance_type'] from powervm driver.

This is one change in a series aimed at removing the use of instance-linked
instance_type objects, in favor of the decoupled type data in
system_metadata. See bug 1140119 for more details.

Change-Id: I885a807d00f7f909665da6e7a3382295a43258c9
Remove uses of instance['instance_type'] from libvirt driver.

Note that this includes a few tweaks to the libvirt tests where the instance
type in use was expected to have no swap, but the actual id-matching fake
did. This integration makes it a little harder for the tests to be out
of whack like that, which is good.

This is one change in a series aimed at removing the use of instance-linked
instance_type objects, in favor of the decoupled type data in
system_metadata. See bug 1140119 for more details.

Change-Id: I190258bd0947944d9bcdf49956eed40d402606f5
Remove uses of instance['instance_type'] from nova/compute

Note that some tests were verifying things that can no longer fail, namely
rebuilding instances who use flavors that have since been disabled. These
tests are removed here.

Also, this changes the order of a piece of logic in the resize/migrate
path where before we would have ended up checking the instance type that
we fetched from sys_meta to see if it was disabled (which makes no sense
now). Reversing the check (to see if we're doing a resize or a migrate
before checking the new flavor) eliminates the problem of the stashed
type not having the 'disabled' attribute.

This is one change in a series aimed at removing the use of instance-linked
instance_type objects, in favor of the decoupled type data in
system_metadata. See bug 1140119 for more details.

Change-Id: I214a693e3bb16c0a365eb9b3afe73601beba4a22
Remove uses of instance['instance_type'] from nova/network

This is one change in a series aimed at removing the use of instance-linked
instance_type objects, in favor of the decoupled type data in
system_metadata. See bug 1140119 for more details.

Change-Id: I43c9e9b7d560d8803899360bd7142e393b793f3d
Remove uses of instance['instance_type'] from nova/api

This removes a test that attempted to delete the data from the
instance['instance_type'] structure and confirm that the flavor can
still be fetched. Since this data is no longer consulted in that
action (and will be removed altogether soon), this test is removed.

This is one change in a series aimed at removing the use of instance-linked
instance_type objects, in favor of the decoupled type data in
system_metadata. See bug 1140119 for more details.

Change-Id: I3ba56f9419aece5b9269a181264d09b117ecdb81
Remove uses of instance['instance_type'] from nova/scheduler

This is a tiny change in the actual code, but requires a bunch of
silly changes in the tests because we're so inconsistent with our
(ab)use of instance types there. This attempts to help clean that
up locally a bit.

This is one change in a series aimed at removing the use of instance-linked
instance_type objects, in favor of the decoupled type data in
system_metadata. See bug 1140119 for more details.

Change-Id: Ied1a944a7c762129597d18ded61ce1632657f070
Merge "Remove uses of instance['instance_type'] from powervm driver."
Merge "Remove uses of instance['instance_type'] from libvirt driver."
Merge "Remove uses of instance['instance_type'] from nova/compute"
Merge "Remove uses of instance['instance_type'] from nova/network"
Merge "Remove uses of instance['instance_type'] from nova/api"
Merge "Remove uses of instance['instance_type'] from nova/scheduler"
Merge remote-tracking branch 'm_src_repo/master' into build-temp