Fix pep8 issues with test_manager.py

Fixes E231 (missing whitespace) problems with
nova/tests/network/test_manager.py

Change-Id: I99d4c3bf7ed1a137fbfb26e9fe2f31d9104d5ae4
More gracefully handle TimeoutException in test

Sometimes although the test_killed_worker_recover test passes, the
cleanup of a forked child takes too long and a TimeoutException
occurs. This patch better handles the TimeoutException and
ensures the child process is killed.

Fixes bug #1128574

Change-Id: I39ea2fbb6c9cb95ad10b68bfa216686467951a93
ensure we run db tests in CI

CI had a set of environmental variables that refused to allow the
tests from failing gracefully. These seem to have gotten lost
along the way in refactoring.

Change-Id: Ib19b5d472c51ed72b8acf1571dd19f41474532c5
Removed duplicate spawn code in PowerVM driver

After introducing resize/migrate in PowerVM there was
some code that was duplicated after a rebase. The commit
removes the duplicate code. The functionality of
resize/migrate remains the same as introducted in
Change I72345626

Bug #1130680

Change-Id: I1fe3d8e1f2a19fd40a03c8c38d90c01711356b38
libvirt: fix volume walk of /dev/disk/by-path

If /dev/disk/by-path does not exist, then _get_iscsi_devices() will
raise an IndexError. Handle this case and return an empty list. This
fixes a test on OSX.

Fixes bug 1130841

Change-Id: Ibae2f1238feac9a10b8dc2b74886ea59edac0bcc
Identify baremetal nodes by UUID.

- add a new 'uuid' column to 'bm_nodes' table
- provide a new db/api method for accessing nodes by their uuid
- return this to Nova as the nodename / hypervisor_hostname

In this way, a baremetal node is uniquely identified to the user,
whether they use a per-compute baremetal db or global baremetal db.

It will also allow for an instance to be booted on a specific baremetal
node using a means akin to the current force-hosts (TBD in later patch).

Also, creates two new Exceptions to disambiguate between
InstanceNotFound and NodeNotFound / NodeNotFoundByUUID.

Change-Id: I81105a201588fdef31cffabdae260bb43017bcd1
Baremetal driver returns accurate list of instance

Add 'instance_name' to bm_nodes table so that baremetal driver is able
to return the names of all instances it believes are still running.

Previously, baremetal.driver.list_instances was fetching all allocated
instances from baremetal database, then calling VirtAPI to get the
instance name. This would raise an InstanceNotFound exception for
deleted instances. This prevented ComputeManager from ever detecting
a running-but-deleted baremetal instance, and could leave baremetal
instances in an undeletable state.

Fixes bug 1096723.

Change-Id: Ifae532e8e70e97e48c589608cb3c7000bb6a7609
Remove race condition (in Networks)

Soft delete all duplicate rows with the same vlan except one with
the biggest value in `id` column.

Create UC on fields (vlan, deleted)

Replace Select then Insert -> Try to Insert.

Fix error in network_update method. We were able to update
vlan to duplicate.

Fix typo in description of method drop_old_duplicate_entries_from_table()

blueprint db-enforce-unique-keys

Change-Id: Ia1b58ab5a5e369a1939de0b5c2f89aee6fc2c40b
Merge "Identify baremetal nodes by UUID."
Merge "Baremetal driver returns accurate list of instance"
Merge "Remove race condition (in Networks)"
Merge "Removed duplicate spawn code in PowerVM driver"
Merge "libvirt: fix volume walk of /dev/disk/by-path"
Merge "ensure we run db tests in CI"
Merge "More gracefully handle TimeoutException in test"
Merge "Fix pep8 issues with test_manager.py"
Merge remote-tracking branch 'm_src_repo/master' into build-temp