I fixed both comment.


On Fri, Aug 2, 2013 at 10:57 AM, lamblin <notifications@github.com> wrote:

> In doc/extending/ctype.txt:
>
> >
> > -Note that you should not call ``register_OutputGuard_c_code`` with your
> > -new type if this type is not associated to Python objects in the C code,
> > -as otherwise the reference count mechanism will crash. For instance,
> > -the ``Double`` type described here is associated to ``double`` objects
> > -in the C code, and consequently this type should not be registered in
> > -OutputGuard.
> > +The version parameter is what is returned by
> > +DeepCopyOp.c_code_cache_
> version(). By default, it will recompile the c
> > +code for each process.
> > +
> > +.. note::
> > +
> > +   This is an old note. I'm note sure if it is still true or
> > +   not. register_OutputGuard_c_code have already been replaced with
> > +   register_view_op_c_code. We need to check what happen in that case.
>
> Now, register_view_op_c_code works exactly like for DeepCopyOp. There is
> no need to mention register_OutputGuard_c_code anymore. The warning does
> not apply now that we can specify which C code to register.
>
> I would remove that note entirely, but add the same instructions as for
> register_deep_copy_op_c_code, like:
> "As for register_deep_copy_op_c_code, in your C code, you should use
> %(iname)s and %(oname)s to represent
> the C variable names of the ViewOp input and output
> respectively. See an example for the type CudaNdarrayType (GPU
> array) in the file theano/sandbox/cuda/type.py."
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Theano/Theano/pull/1472/files#r5554578>
> .
>