Fixes and comments on iscsi_look_for_stuff(); snprintf, small optimization. Fixes and comments on iscsi_read_sysfs_value(); if instead of while, strdup return check. Fixes and comments on iscsi_write_sysfs_value(); snprintf instead of sprintf, check fputs for EOF.
Comment on iscsi_write_sysfs_value(). A lot of fixes and comments on iscsi_generate_target(); incorrect usage of strncpy (was using sizeof() on wrong argument), use same size for all domain string variables, null first byte in some variables that could be checked with strlen() without having been used, check num of tmp[] so a string with 20 or more dots don't segfault, snprintf checks.
Input checking of functions already looked at. Fixes and comments on iscsi_generate_device_name().
On iscsi_retrieve_sessions_iet() and iscsi_read_sysfs_value(); Removing trailing CR LF correctly on two places. Fixes and comments on iscsi_retrieve_sessions_iet().
Add iscsi_dirs_free() to free a chain of iscsi_dirs_t. Do not need to NULL at exit in iscsi_retrieve_sessions_iet(). Comments and fixes in iscsi_retrieve_sessions_scst() many memory leaks and unchecked returns.
Merge branch 'iscsi+crypto+mine' of git://github.com/jelu/zfs into iscsi+crypto+mine+prox
* Use assert() where needed.
* Fix tabbing and coding style.
* Replace remaining sprintf() with snprintf().
* Add remaining check for return value from snprintf()'s and functions.
* Add remaining free()'s.
* Remove iscsi_dirs_free_list(). Wasn't working, and seems redundant.
  + Replace with normal free() (free'ing correct variable).
* Check return from iscsi_look_for_stuff().
* Remove some free()'s that free'd variables not *alloc'ed.