Core/Script: Code style and some rewriting.

MoveInLineOfSight(Unit* unit) -> MoveInLineOfSight(Unit* who)
thanks to gyx

Signed-off-by: bootz <bootz@projectskyfire.org>
Core/Shared: Move container functions to shared project under SkyFire::Container namespace. Also implement RandomResizeList which takes a predicate function as parameter.

Core/ScriptedAI: Extend SummonList::DoAction to take a predicate function as parameter and allow specifying a maximum number of units to be selected.

Signed-off-by: bootz <bootz@projectskyfire.org>
Core/Scripts: Remove some unnecessary creature/player casts in scripts and do some safer casting in a silithus script

Scripts/Kalimdor: Silithus script clean-up and corrections.

Signed-off-by: bootz <bootz@projectskyfire.org>
Core/Misc: Add a validity check for coordinates, prevents possible crashes with invalid coordinates

Signed-off-by: bootz <bootz@projectskyfire.org>
Core/Ai: Fixed couple wrong return types

Signed-off-by: bootz <bootz@projectskyfire.org>
Core/Script: Use DoMeleeAttackIfReady in default ScriptedAI::UpdateAI method (fixes offhand attacks if not UpdateAI is overridden)
DB/Spells: Fix Honor Among Thieves proc chance

Signed-off-by: bootz <bootz@projectskyfire.org>
Core/DB: Quest The Emissary

Signed-off-by: bootz <bootz@projectskyfire.org>
Core/Scripting: Fix DoAction function of SummonList incorrectly removing entries in SummonList

Signed-off-by: bootz <bootz@projectskyfire.org>
Core/Ai: Cleanup's and corrections

Signed-off-by: bootz <bootz@projectskyfire.org>
fixed header

Signed-off-by: bootz <bootz@projectskyfire.org>
Scripts/Miscellaneous: Enable const-ness for various functions in ScriptedAI (Author: DorianGrey)
- Improve codestyle, since objects internal state is not changed here
- Make these functions available for inherited CanAIAttack() function
thanks to Elron103

Signed-off-by: bootz <bootz@projectskyfire.org>
Core/Spells: Fix some summon vehicle spells with basepoint 1
thanks to vincent-michael

Signed-off-by: bootz <bootz@projectskyfire.org>
Core/Players: updated health regeneration to cataclysm.
thanks to NorthStrider

Signed-off-by: bootz <bootz@projectskyfire.org>
Core/Players: Replacing troll radical for health regen rate.
- removed accidentally by last commit

Signed-off-by: bootz <bootz@projectskyfire.org>
Core/BossAI: Fix a typo in CheckBoundary

Method was using "me" (the boss) instead of the function's argument

Props to @Horn for finding the 4yo. error

Signed-off-by: bootz <bootz@projectskyfire.org>
Auth/Realmlist: Make use of RealmFlags and rename color to flag (core- and dbwise)

Also fix connecting with realmflag & 4
thanks to Shauren

Signed-off-by: bootz <bootz@projectskyfire.org>
Merge branch 'master' of https://github.com/ProjectSkyfire/SkyFireEMU
Core/Containers: Fixed build under nix *closes  Issue #860
thanks to -spp

Signed-off-by: bootz <bootz@projectskyfire.org>
Removed local file, this was not to be pushed :s

Signed-off-by: bootz <bootz@projectskyfire.org>