does now %s provide for the installdir? other than that, code-style wise looks good.