You're right: I started to go through and remove them from my version but I
got sidetracked.

-Kevin


On Mon, Sep 9, 2013 at 4:15 PM, Pierre-Alexandre Meyer <
notifications@github.com> wrote:

> In src/main/resources/sanity/sanity.sql:
>
> > -or (coalesce(ii.start_date, '') != coalesce(bii.start_date, ''))
> > -or (coalesce(ii.amount, '') != coalesce(bii.amount, ''))
> > -or (coalesce(ii.currency, '') != coalesce(bii.currency, ''))
> > -or (coalesce(ii.linked_item_id, '') != coalesce(bii.linked_item_id, ''))
> > -or (coalesce(ii.created_date, '') != coalesce(bii.created_date, ''))
> > -or (coalesce(ii.account_record_id, '') != coalesce(bii.account_record_id, ''))
> > -or (coalesce(ii.tenant_record_id, '') != coalesce(bii.tenant_record_id, '')))
> > -;
> > +      and (( coalesce(ii.record_id, '') != coalesce(bii.invoice_item_record_id,''))
> > +      or ( coalesce(ii.id, '') != coalesce(bii.item_id,''))
> > +      or ( coalesce(ii.type, '') != coalesce(bii.item_type,''))
> > +      or ( coalesce(ii.invoice_id, '') != coalesce(bii.invoice_id,''))
> > +      or ( coalesce(ii.account_id , '')!= coalesce(bii.account_id,''))
> > +      or ( coalesce(ii.phase_name, '') != coalesce(bii.slug,''))
> > +      or ( coalesce(ii.start_date, '') != coalesce(bii.start_date,''))
> > +      -- RI-1986 or ( coalesce(ii.end_date, ii.start_date + interval 30 day) != coalesce(b.end_date,''))
>
> This doesn't work for trials shorter than 30 days, no? I was thinking of
> skipping that check.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/killbill/killbill-analytics-plugin/pull/1/files#r6254072>
> .
>



-- 
Kevin Postlewaite