began making make_trade function