On 06/27/2013 09:29 AM, Anoop Saldanha wrote:
> In src/app-layer-dcerpc.h:
> 
>> -} DCERPCState;
>> +struct DCERPCState;
>> +
>> +/*****linked list implementation*****/
>> +
>> +/* we will think about moving it to its own file next */
>> +
>> +struct List {
>> +    void *head;
>> +    void *tail;
>> +
>> +    int index;
>> +    int size;
>> +};
>> +
>> +#define ListNext void
> 
> The last discussion we had - You, eric and I, you specified that you
> want to move away from typedef'ing types to specifying it using the
> whole "struct ...".
> 
> Which is why I didn't typedef it. I can typedef it back, although the
> non-typedef version has grown on me, tbh.

Yeah, although I don't think we decided yet to move over. The problem is
that if we change this I would like to change over completely. Not mix
the styles.