finished update tab, have to handle controller