OK, agree. I'll rename it to GetDateTimeTaken. I guess I squash the new
commit as well.
 On Mar 7, 2013 3:18 PM, "Sascha Montellese" <notifications@github.com>
wrote:

> In xbmc/pictures/PictureInfoTag.h:
>
> > @@ -101,11 +102,20 @@ class CPictureInfoTag : public IArchivable, public ISerializable, public ISortab
> >
> >    void SetInfo(int info, const CStdString& value);
> >
> > +  /**
> > +   * GetDateTime() -- Returns the EXIF DateTimeOriginal for current picture
> > +   *
> > +   * The exif library returns DateTimeOriginal if available else the other
> > +   * DateTime tags. See libexif CExifParse::ProcessDir for details.
> > +   */
> > +  const CDateTime& GetDateTime() const;
>
> From a general XBMC point of view IMO something like GetDateTimeTaken() or
> something like that would be more obvious. I'm not sure what other
> date/time values there are for a picture (apart from the usual file times
> like created, modified, last accessed etc which are handled by CFileItem)
> but IMO choosing a good name is better than having to open the header file
> to read the comment to know what date/time it represents.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/xbmc/xbmc/pull/2377/files#r3277243>
> .
>