So it looks like there are some minor things that need to be done (i.e., 
you're rejecting the pull request). When the team this year meets 
tomorrow we'll plan on getting these things done and resubmit the pull 
request. Do you need to formally reject the pull request?

     --Gary

-- 
Gary Pollice                                gpollice@cs.wpi.edu
Professor of Practice, Computer Science     gpollice@computer.org (alternate)
Worcester Polytechnic Institute             Office: 508-831-6793
100 Institute Road                          Mobile: 978-798-0019
Worcester, MA 01609-2280                    <http://www.cs.wpi.edu/~gpollice/>

On 9/15/13 7:53 PM, Andrew Hurle wrote:
>
> In Janeway/build.xml:
>
> > @@ -8,6 +8,24 @@
> >  		<fileset dir="${core-lib}">
> >  			<include name="commons-codec-1.7.jar"/>
> >  		</fileset>
> > +		<fileset dir="../Janeway/lib">
> > +			<include name="jfreechart-1.0.14.jar"/>
> > +		</fileset>
> > +		<fileset dir="../Janeway/lib">
> > +			<include name="jcommon-1.0.17.jar"/>
>
> You should be able to put all these |include|s in a single fileset. 
> I'd also like to see |../Janeway/lib| replaced with something like 
> ${core-lib} above.
>
> And let it be known that this stuff was a crappy hack to get libraries 
> working in Janeway. It's not a sustainable model.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/WPI-Suite/wpi-suite/pull/4/files#r6368597>.
>