This prevents the supervisor from going down. I need to look into this
again but we may have added a out of band clean up job to clean up. I have
a few other things I need to follow up on I'll get back to you on this.
 Thanks Nathan.


On Tue, Jul 30, 2013 at 6:42 PM, Nathan Marz <notifications@github.com>wrote:

> In src/clj/backtype/storm/daemon/supervisor.clj:
>
> > @@ -160,7 +163,9 @@
> >        (psim/kill-process thread-pid))
> >      (doseq [pid pids]
> >        (ensure-process-killed! pid)
> > -      (rmpath (worker-pid-path conf id pid))
> > +      (try
> > +        (rmpath (worker-pid-path conf id pid))
> > +        (catch Exception e)) ;; on windows, the supervisor may still holds the lock on the worker directory
>
> I don't quite understand... so in this case will it be cleaned up
> appropriately or not?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/nathanmarz/storm/pull/603/files#r5494050>
> .
>