That sounds reasonable.


On Mon, Jan 7, 2013 at 5:58 PM, Wesley Beary <notifications@github.com>wrote:

> In lib/excon/socket.rb:
>
> > @@ -80,9 +83,7 @@ def connect
> >
> >      def read(max_length=nil)
> >        return nil if @eof
>
> @davelnewton <https://github.com/davelnewton> - I'm ok with it returning
> also, for clarity, but tend to avoid inline conditionals (they are slightly
> less performant and personally I find that they are often harder to read).
> Anyway, you can ignore this, it is the same as it was before and I can
> always tweak it later if it really gets to bugging me.
>
> @proxy is set by other internals (and not direct end-user input) so it
> should be setable safely, at least in it's current incarnation, so perhaps
> just setting it to the same value as params[:family] is a good place to
> start anyway? If we find that it should be changeable it would probably be
> via a :proxy_family param or something I would guess, but we can cross
> that bridge if/when we need to.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/geemus/excon/pull/178/files#r2571104>.
>
>



-- 
e: davelnewton@gmail.com
m: 908-380-8699
s: davelnewton_skype
t: @dave_newton <https://twitter.com/dave_newton>
b: Bucky Bits <http://buckybits.blogspot.com/>
g: davelnewton <https://github.com/davelnewton>
so: Dave Newton <http://stackoverflow.com/users/438992/dave-newton>