Remove an obsolete test for /r/new/.

The "New Review Request" view has been rewritten to be javascript/API driven,
and no longer has a form to submit, so having a test that submits form data
isn't very useful.
Escape user and group names when using AD filters.

We weren't escaping things before passing them into the ldap libraries, which
meant that trying to do something like an AD group named "C# Users" would cause
an error. This change makes use of ldap.filter.filter_format instead of raw
string formatting.

Fixes bug 2928.
Fix pre-formatting of the text for the authentication reset command.

The prior paragraph wasn't terminated with ::, which meant that rst changed the
-- to emdashes. Boo rst.
Fix the "Open an issue" checkbox.

There were a handful of problems with the "open an issue" checkbox in the
comment dialog, mostly introduced when I marked the javascript strings for
translation:

- The form field used "name" instead of "id", which meant that clicking on
  the label didn't work.
- The "Open an issue" text has an underline on the "i", presumably to denote
  an access key, but it was formatted into the template with HTML escaping.
- The <label> element has an accesskey attribute that we weren't defining.

Testing done:
- Created new comments and edited old ones, changing the issue state.
- Verified that clicking on the label changed the state of the checkbox.

Reviewed at https://reviews.reviewboard.org/r/4465/
Improve our support for inline review UIs.

The original codebase for review UIs prepared the groundwork for
displaying a review UI inline into part of a page, without needing its
own full Review Board page. It was never used in practice, and its
design assumed it would still sit alone on its own page, but a simple
one embedded in an iframe.

The new design allows it to be embedded into any container on a page.
That makes it easier to include in popups, the diff viewer, etc.

The defaut template now places all scripts inside of a new
review_ui_scripts block, which is placed in the correct place in
base.html. base_inline.html is stripped down to just include the page
content and scripts.

The ReviewUI class now provides a render_to_string function, which
render_to_response wraps. This does all the rendering of the template,
based on the parameters and ReviewUI configuration.

There's a template tag to render the ReviewUI into a template. It's
unused in this change, but will be used in an upcoming change.
If there's only one repository, auto-select it for new Review Requests.

A lot of our users have only a single repository. In the new review request
page, if we're in this situation, auto-select the repository, to reduce one
click.

Testing done:
Set visible=False for all but one of my repositories. Went to /r/new and saw it
automatically select the remaining one. Un-hid my repositories and saw the
"Select a repository" message.

Reviewed at https://reviews.reviewboard.org/r/4472/
Fix HTML escaping for localized strings in javascript.

There were a handful of other strings containing HTML in the javascript which
were localized with gettext, but then inserted into an underscore template in a
way that would escape the HTML. I've gone through all of the occurrences of
"gettext" and made sure that anything containing HTML tags is formatted using
<%= %> instead of <%- %>.

Testing done:
Checked the pre-commit and comment dialog UIs to verify the fixed text.

Reviewed at http://reviews.reviewboard.org/r/4469/
Add icons for search, jump-to, start to use them in the new review request page.

This change adds new icons to our spritesheet for searching the repository
list, and a sort of jump-to icon to denote revisions which already have an
existing review request. The jump-to icon is used as part of this change.
Search will be used in a later change.

Testing done:
- Created a few review requests for committed revisions, then went back to the
  new review request page. Saw the jump-to icon in the right spot.
- Added a div for the search icon using the chrome devtools and saw that it
  looked nice in context.

Reviewed at http://reviews.reviewboard.org/r/4470/
Fix up pep-8 issues in some more apps directories.

This fixes up many of the pep8 issues in the extensions, hostingsvcs,
notifications, and reviews directories.

Testing done: ran unit tests.
Reviewed at http://reviews.reviewboard.org/r/4474/
Move the main diffviewer views to extensible class-based views.

Django's pushing for class-based generic views for things, and in the
case of the diff viewer, it provides a lot of advantages.

So far, diffviewer has had a nice separation, where the code in
diffviewer was able to focus solely on diff-related work, and the code
in reviews was able to focus on objects related to review requests. This
was getting hard to maintain with the new review UI support in the diff
viewer, though, and it was clear a more extensible solution was needed.

Now, the code for rendering the diff viewer and diff fragments are
class-based. This simplifies part of the code, and gives us a foundation
for some better extensibility by subclasses. The code in reviews will
soon be able to do a lot more with the resulting renders without having
to inject a bunch of new code into diffviewer.

No logic was changed, but much of the code moved around.

Going forward, some mixins for things like fetching review request data
and checking login support will be created to reduce what these classes
have to do. I'm leaving them out of this change, though.
Remove the base_url parameter for diff rendering.

We used to need this silly base_url parameter for rendering diffs. We
used it for bits of the JavaScript. It's unused now, but we're still
passing it around, so stop doing that.