Being new to this, should I fix this and add to the PULL request?

 

Thanks
Sjcbulldog

 

From: Alexander Schepp [mailto:notifications@github.com] 
Sent: Sunday, March 10, 2013 11:11 AM
To: essentials/Essentials
Cc: sjcbulldog
Subject: Re: [Essentials] Added the ability to set the price on a buy or sell sign based on the wo... (#376)

 

In Essentials/src/com/earth2me/essentials/signs/EssentialsSign.java:

> +                    return;
> +            }
> +            
> +            if (line.equalsIgnoreCase("$$"))
> +            {
> +                    double price = ess.getWorth().getPrice(item) ;
> +                    if (Double.isNaN(price))
> +                    {
> +                            throw new SignException("no price set for item") ;
> +                    }
> +                    else
> +                    {
> +                            price = Math.round(price * scale * 100) / 100.0 ;
> +                            int amount = getIntegerPositive(sign.getLine(amountIndex));                   
> +                            price *= amount ;
> +                            sign.setLine(costIndex, "<" + Util.shortCurrency(price, ess) + ">") ;

No line length check here.

—
Reply to this email directly or view it on GitHub <https://github.com/essentials/Essentials/pull/376/files#r3310212> .  <https://github.com/notifications/beacon/-Zz_g9szlaiPAgMxcX3VbVaOpznlVV_Gv9-um-c0HogbzWVR09Ygj2adjX3xh0WM.gif>