Yea, I've since changed this in users+groups search PR. This method is actually removed now. 

Sent from my iPhone

On 2013-02-10, at 11:13 AM, nicolaasmatthijs <notifications@github.com> wrote:

> In node_modules/oae-search/lib/util.js:
> 
> > @@ -58,8 +58,13 @@ var getQueryParam = module.exports.getQueryParam = function(val, defaultVal) {
> >   * @return  {String}                `val` if it is valid. `defaultVal` otherwise.
> >   */
> >  var getResourceTypeParam = module.exports.getResourceTypeParam = function(val, defaultVal) {
> > -    defaultVal = defaultVal || SearchConstants.general.RESOURCE_TYPE_ALL;
> > -    return val || defaultVal;
> > +    defaultVal = _.contains(SearchConstants.general.RESOURCE_TYPES, defaultVal)?defaultVal:SearchConstants.general.RESOURCE_TYPE_ALL;
> @mrvisser: This means that it is impossible to add a new resource type without changing the core code. I'd rather have us check the registered search/resource types, rather than check the SearchConstants.general.RESOURCE_TYPES constant.
> 
> —
> Reply to this email directly or view it on GitHub..
>