Adding fencing parameters to log print

Change-Id: Ic14f3ae9e302ffaf8e4fc883f2a177864e512c4f
Signed-off-by: Yaniv Bronhaim <ybronhei@redhat.com>
packaging: Added encodingvalidator.sh to validation list

This patch updates encodingvalidator.sh utility and adds
it to the list of executed validators in validatedb.sh
generic script.

Change-Id: Ic89088c7738eb379b2bc88d8d59193d4ed20a295
Bug-Url: https://bugzilla.redhat.com/920565
Signed-off-by: Alex Lourie <alourie@redhat.com>
core: Allow editing a bootable disk

Fixed a couple of bugs in getOtherVmDisks(Guid) to allow editing a
bootable disk:
1. Once the list of disks is produced, it should be saved in the cache
   map
2. The break statement should be inside the if, not after it.

Change-Id: I111de3ff5710d29d1301c0c47e12755d88e016b9
Bug-Url: https://bugzilla.redhat.com/959761
Signed-off-by: Allon Mureinik <amureini@redhat.com>
engine:Sync gluster hooks

This patch adds a periodic job to sync gluster hooks
on servers in the cluster with the hooks stored in database.

Every execution of the job
- Retrieves the list of hooks from each server in the cluster
- Compares the list with the saved data in database
- If different, inserts or updates the database
- Changes conflict status in db, if any status, content or missing
conflict detected.

Added GlusterHooksEnabled to GlusterFeatureSupported.

Change-Id: I2766edd4e810677a200cf5c45d334cabef5f2924
Signed-off-by: Sahina Bose <sabose@redhat.com>
core: Remove stdout from SimpleAuthenticationCheck

Removed an old System.out.println call from the class - it was probably
left there by mistake during debugging, and in any event has no place in
production code.

Change-Id: I1ac20e5aa5d9a8236a2a081c5cd0be68a25f724b
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: Removed std from KDCLocatorTest

Removed printing of results with System.out.println - this is no way to
handle robust logging.

Change-Id: I37eac9646bcbabe3a80a563e41d7bd904de626cd
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: Removed std from EncryptionUtilsTest

Removed printing of results with System.out.println - and replaced it
with a proper error message in case of failure.

Change-Id: Ia1386b1ddb0e090e5c49a6c3130a3dccfb35a365
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: Synthetic emulators EcryptionUtilsTest

Changed members visibility from private to protected to solve the
synthetic emulators warning.

This may slightly increase performance, but I doubt it will be
noticeable.

Change-Id: I5d17aa584e4b8c1d858d74c155265a9f30cf86d0
Signed-off-by: Allon Mureinik <amureini@redhat.com>
core: EncryptoinUtilsTest @Before->@BeforeClass

Replaced the @Before method with @BeforeClass.
There is a single URL that won't change between test runs.

Change-Id: I89ad4e12f08af5e0ef19e486bf21c350ad7f1015
Signed-off-by: Allon Mureinik <amureini@redhat.com>
tools: Proper error testing in EngineConfigCLITest

Converted the error tests in EngineConfigCLITest to the proper JUnit
form (with the expect parameter on the @Test annotation), instead of the
awkward explicit fail before the catch block.

Since the test methods have meaningful names, this change also allowed
removing the System.out.println calls.

Change-Id: Iad25eae4fd7b4535cc1b2d9570f142d6996b79d0
Signed-off-by: Allon Mureinik <amureini@redhat.com>
findbugs: self comparison of user to itself

Change-Id: Ifa88e752da82043857f27d334ba86ca1c5587bcd
Signed-off-by: Shahar Havivi <shavivi@redhat.com>
engine: ConcurrentModificationException failing domain/host fail process

The following bugs were caused because of trying to iterate over collection and in
the same time (inside an iteration) try to modify it.
In order to solve a bug I removed one of the problematic collections, and move all logic to work
with one collection

Change-Id: Ie4e401263a6839370c7fccbf77b05d866fc06145
Bug-Url: https://bugzilla.redhat.com/958095
Bug-Url: https://bugzilla.redhat.com/958186
Signed-off-by: Michael Kublin <mkublin@redhat.com>
core:running the db scripts manually with user...

running the db scripts manually with user posgres will change the table permission and upgrade will fail since user engine cannot change tables

Setting user "engine" as the deault user for all the following
utilities:

backup.sh
create_db.sh
create_db_devel.sh
create_schema.sh
encryptionvalidator.sh
encodingvalidator.sh
exportDbSchema.sh
fkvalidator.sh
refreshStoredProcedures.sh
restore.sh
taskcleaner.sh
unlock_entity.sh
upgrade.sh

Change-Id: I8ae8999dcfad53a1e62613dbff915f76b32e89de
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=958765
Signed-off-by: Eli Mesika <emesika@redhat.com>
findbugs: toString may return null

Change-Id: I7540e6cfadb76f742f5b9959418b5e0a6cbf4fed
Signed-off-by: Shahar Havivi <shavivi@redhat.com>
findbugs: Class define clone but not cloneable

Change-Id: I5474832e1a9b26279bdc2e2d79546104fe74ee49
Signed-off-by: Shahar Havivi <shavivi@redhat.com>
findbugs: EndedTaskInfo defines non-serializable instance field

Change-Id: I41ca491586d360f064fcee99165ee8486531c816
Signed-off-by: Shahar Havivi <shavivi@redhat.com>
userportal,webadmin: bring back change CD menu to SPICE console

This has been lost while moving from 3.0 to 3.1.

This patch contains:
- setting the correct menu to the ActiveX plugin (XPI
plugin does not have this functionality)
- listening to the onmenuitemselected event and firing the correct
event in response
- fix the menu item creation - new StringBuilder(int) just creates the
empty string (int param means the capacity, not the actual content)
- fix the format of the menu
- removed items which are not handled by us anymore, but handled
by the spice client itself

Change-Id: Ifdfa982da00ae333271f60795b0c17fe602e14ef
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=957611
Signed-off-by: Tomas Jelinek <tjelinek@redhat.com>
engine: search remove redundant constructor param (1/N)

Removed a parameter from AutoCompletionField constructor, it was
practically always equal to another parameter.

Change-Id: I28129e1549232ba33db8b91ed9c5bd8061ad24f2
Signed-off-by: Laszlo Hornyak <lhornyak@redhat.com>
frontend: Fixed default color depth for spice-activex

This patch fixes setting default value of ColorDepth attribute of spice browser
plugin. For spice-xpi the value is "", whereas for spice-activex the value
is 0.

Change-Id: I58af05c0a2ff88dccb4634ec9a81dff84afe92a5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=913183
Signed-off-by: Frantisek Kobzik <fkobzik@redhat.com>
core: Introducing findbugs filter to bll module

Introducing findbugs to bll module.
In order to generate findbugs report use
"mvn site" and look for findbugs.xml at the target/site
directory (this may take several minutes)

Marking as WIP as obviously this should be implemented to
other modules.
I would like you to review and share your opinions

Thanks

Change-Id: I26b9cafc1832022693a7386277972a7e48a53f0d
Signed-off-by: Yair Zaslavsky <yzaslavs@redhat.com>