I already discussed this with igorw and we agreed we need a more complete
dumper. I have some code available, I will push it to somewhere, but it's
useless -- we need to think through first what format of the Definition
dump should take. Should it be inlined? If not, then should it change the
parent into a non-inlined representation as well?


On Fri, Apr 5, 2013 at 5:37 PM, Christophe Coevoet <notifications@github.com
> wrote:

> In src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php:
>
> > @@ -315,6 +315,8 @@ private function resolveServices($value)
> >              if (null !== $invalidBehavior) {
> >                  $value = new Reference($value, $invalidBehavior, $strict);
> >              }
> > +        } elseif (is_string($value) &&  0 === strpos($value, '+')) {
> > +            $value = new Definition(substr($value, 1));
>
> This is wrong. the inline definition should either be fully supported
> (i.e. a full service definition, which cannot be done with a string) or not
> at all (the current state). But supporting only the class name without any
> of the settings is a no-go (and would still make the dumper wrong as
> dumping and loading would not recreate the same definition)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/symfony/symfony/pull/7526/files#r3682709>
> .
>