[EFL][CoordinatedGraphics] Clear m_contentsSize when new contents are loaded
https://bugs.webkit.org/show_bug.cgi?id=125033

Reviewed by Gyuyoung Kim.

m_contentsSize should be cleared when new contents are loaded so that PageViewportController
would take care of newly loaded contents with same size as previous one.
It's because PageViewportController is cleared not to make wrong behaviour
while loading when new contents are committed.

* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
Improve tests to check contents,size,changed signal when loaded contents having
same size with previous one.
* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::didCommitLoadForMainFrame): Cleared m_contentsSize.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Mac] Transition MiniBrowser to the Cocoa API: policy delegate   
https://bugs.webkit.org/show_bug.cgi?id=125046

Reviewed by Sam Weinig.

* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate newWindow:]): Added WK_API_ENABLED guards.
(-[BrowserAppDelegate openDocument:]): Ditto.
* MiniBrowser/mac/WK2BrowserWindowController.h: Ditto. Also moved ivar declarations from the
interface to the implementation.
* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]): Changed to set the policy delegate instead of
the policy client.
(-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
Moved policy client implementation into this delegate method.
(-[WK2BrowserWindowController browsingContextController:decidePolicyForNewWindowAction:decisionHandler:]):
Ditto.
(-[WK2BrowserWindowController browsingContextController:decidePolicyForResponseAction:decisionHandler:]):
Ditto.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[CTTE] The WebPageProxy's WebProcessProxy is never null so it should be stored in a Ref
https://bugs.webkit.org/show_bug.cgi?id=125047

Reviewed by Dan Bernstein.

* UIProcess/API/C/WKPage.cpp:
* UIProcess/API/C/mac/WKPagePrivateMac.cpp:
* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
* UIProcess/API/mac/WKView.mm:
* UIProcess/Downloads/DownloadProxy.cpp:
* UIProcess/Downloads/DownloadProxy.h:
* UIProcess/Downloads/DownloadProxyMap.cpp:
* UIProcess/Downloads/DownloadProxyMap.h:
* UIProcess/DrawingAreaProxy.cpp:
* UIProcess/GeolocationPermissionRequestManagerProxy.cpp:
* UIProcess/Network/NetworkProcessProxy.cpp:
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:
* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
* UIProcess/WebContext.cpp:
* UIProcess/WebContext.h:
* UIProcess/WebEditCommandProxy.cpp:
* UIProcess/WebFrameProxy.cpp:
* UIProcess/WebFullScreenManagerProxy.cpp:
* UIProcess/WebInspectorProxy.cpp:
* UIProcess/WebPageGroup.h:
* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:
* UIProcess/WebProcessProxy.cpp:
* UIProcess/WebProcessProxy.h:
* UIProcess/cf/WebPageProxyCF.cpp:
* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
* UIProcess/mac/RemoteLayerTreeHost.mm:
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
* UIProcess/mac/WebFullScreenManagerProxyMac.mm:
* UIProcess/mac/WebInspectorProxyMac.mm:
* UIProcess/mac/WebPageProxyMac.mm:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix the iOS build.

* UIProcess/API/ios/WKContentView.mm:
* UIProcess/API/ios/WKInteractionView.mm:
* UIProcess/ios/WebPageProxyIOS.mm:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed EFL Build fix attempt after r159903

* UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:
(WebKit::CoordinatedDrawingAreaProxy::layerHostingModeDidChange):
(WebKit::CoordinatedDrawingAreaProxy::update):
(WebKit::CoordinatedDrawingAreaProxy::didUpdateBackingStoreState):
(WebKit::CoordinatedDrawingAreaProxy::sendUpdateBackingStoreState):
(WebKit::CoordinatedDrawingAreaProxy::waitForAndDispatchDidUpdateBackingStoreState):
* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::CoordinatedLayerTreeHostProxy):
(WebKit::CoordinatedLayerTreeHostProxy::~CoordinatedLayerTreeHostProxy):
(WebKit::CoordinatedLayerTreeHostProxy::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHostProxy::renderNextFrame):
(WebKit::CoordinatedLayerTreeHostProxy::purgeBackingStores):
(WebKit::CoordinatedLayerTreeHostProxy::commitScrollOffset):
* UIProcess/WebTextChecker.cpp:
(WebKit::WebTextChecker::checkSpelling):
(WebKit::WebTextChecker::changeSpellingToWord):
* UIProcess/WebTextChecker.h:
* UIProcess/WebVibrationProxy.cpp:
(WebKit::WebVibrationProxy::WebVibrationProxy):
(WebKit::WebVibrationProxy::~WebVibrationProxy):
* UIProcess/efl/WebFullScreenManagerProxyEfl.cpp:
(WebKit::WebFullScreenManagerProxy::invalidate):
* UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
* UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::setThemePath):
(WebKit::WebPageProxy::confirmComposition):
(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::cancelComposition):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Cocoa] The PageLoadState::Observer is not being set on iOS
https://bugs.webkit.org/show_bug.cgi?id=125051

Reviewed by Dan Bernstein.

* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::platformInitialize):
Add missing call to _finishInitialization.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Make more computed style helpers return PassRef.
<https://webkit.org/b/125043>

Reduce branchiness in computed style code by making more of the
file-local helpers return PassRef instead of PassRefPtr.

Reviewed by Anders Carlsson.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Give UserMessageEncoders WebProcessProxy reference (like the decoders already have)
https://bugs.webkit.org/show_bug.cgi?id=125053

Reviewed by Dan Bernstein.

- Give the UserMessageEncoders a process reference.
- Switch UserMessageDecoders to storing a process reference, rather than pointer.

* Shared/UserMessageCoders.h:
* Shared/mac/ObjCObjectGraphCoders.h:
* Shared/mac/ObjCObjectGraphCoders.mm:
* UIProcess/WebConnectionToWebProcess.cpp:
* UIProcess/WebContext.cpp:
* UIProcess/WebContextUserMessageCoders.h:
* UIProcess/WebPageProxy.cpp:
* WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r159764.
http://trac.webkit.org/changeset/159764
https://bugs.webkit.org/show_bug.cgi?id=125055

appears to hurt html5-full-render times (Requested by kling on
#webkit).

* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertTextNode):
* html/parser/HTMLConstructionSite.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
CSSFunctionValue constructors should return PassRef.
<https://webkit.org/b/125054>

Make CSSFunctionValue::create() helpers return PassRef instead of
PassRefPtr since they will never return null.

Reviewed by Anders Carlsson.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove unreachable labels for -webkit-margin-*-collapse properties.
<https://webkit.org/b/125057>

The following properties are implemented in DeprecatedStyleBuilder
and should not have case labels in the applyProperty() switch:

    -webkit-margin-before-collapse
    -webkit-margin-top-collapse
    -webkit-margin-after-collapse
    -webkit-margin-bottom-collapse

This seems counter-intuitive, but they are actually *not* like other
directional properties. In this case, before/after are only aliases
for top/bottom, and do not depend on writing-mode or text-direction.
See also r68561, where the aliases were originally added.

Reviewed by Anders Carlsson.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
SVG: Intersection/enclosure checks should use RenderElement.
<https://webkit.org/b/125058>

Make RenderSVGModelObject's checkIntersection() and checkEnclosure()
take RenderElement* instead of RenderObject*. They are only ever
called with SVGElement's renderers.

Reviewed by Sam Weinig.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed Gtk port Build fix after r159903

* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::layerHostingModeDidChange):
(WebKit::DrawingAreaProxyImpl::update):
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::sendUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidUpdateBackingStoreState):
* UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:
(WebKit::WebFullScreenManagerProxy::invalidate):
* UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::setAcceleratedCompositingWindowId):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
HTML5 required attribute validation messages implemented.
https://bugs.webkit.org/show_bug.cgi?id=125003

Patch by Attila Dusnoki <adusnoki@inf.u-szeged.hu> on 2013-12-02
Reviewed by Gyuyoung Kim.

* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::validationMessagePatternMismatchText):
(WebCore::validationMessageValueMissingText):
(WebCore::validationMessageValueMissingForCheckboxText):
(WebCore::validationMessageValueMissingForFileText):
(WebCore::validationMessageValueMissingForMultipleFileText):
(WebCore::validationMessageValueMissingForRadioText):
(WebCore::validationMessageValueMissingForSelectText):
(WebCore::validationMessageBadInputForNumberText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix build warning in EventHandler.cpp
https://bugs.webkit.org/show_bug.cgi?id=125010

Patch by Tibor Meszaros <mtibor@inf.u-szeged.hu> on 2013-12-02
Reviewed by Csaba Osztrogonác.

* page/EventHandler.cpp:
(WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: Remove unused functions from InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=125061

Reviewed by Antoine Quint.

Get rid of unused functions, redundant inclusion and forward declaration.

No new tests, no behavior changes.

* inspector/InspectorAgent.cpp:
* inspector/InspectorAgent.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed GTK gardening.

* Scripts/run-gtk-tests:
(TestRunner): Skip two unit tests that are causing the subsequent test to crash.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[ATK] Support active state for listbox elements.
https://bugs.webkit.org/show_bug.cgi?id=125009

Patch by Andrzej Badowski <a.badowski@samsung.com> on 2013-12-02
Reviewed by Chris Fleizach.

Source/WebCore:

Added support for ATK_STATE_ACTIVE for listbox elements.

* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(setAtkStateSetFromCoreObject):

Tools:

Supplement WebKitTestRunner and DumpRenderTree to support isSelectedOptionActive.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::isSelectedOptionActive):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::isSelectedOptionActive):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::isSelectedOptionActive):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::isSelectedOptionActive):

LayoutTests:

Establish expectations for the test (all PASS).

* accessibility/multiselect-list-reports-active-option-expected.txt: Added.
* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[GTK] GTK2 paint code path does not render AC layers
https://bugs.webkit.org/show_bug.cgi?id=124967

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-12-02
Reviewed by Carlos Garcia Campos.

* webkit/webkitwebview.cpp:
(webkit_web_view_expose_event): also paint AC layers when painting the widget,
when AC is on.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[GTK] Remove unneeded autoconf macros
https://bugs.webkit.org/show_bug.cgi?id=125044

Compilers that do not support const/inline/volatile and
systems with pre-C89-headers are anyway not supported.

Patch by Adrian Bunk <bunk@stusta.de> on 2013-12-02
Reviewed by Gustavo Noronha Silva.

* Source/autotools/CheckSystemAndBasicDependencies.m4:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159928 268f45cc-cd09-0410-ab3c-d52691b4dbfc