This is my first time doing Perl programming. I read recently that adding the () results in great efficiency at runtime. I could also take them out of the sub as they're constant. 


/* Daniel R. Hollingsworth 
* dan@machinepublishers.com 
* tel: 1.855.519.2845 
*/ 

----- Original Message -----

From: "Caine Tighe" <notifications@github.com> 
To: "duckduckgo/zeroclickinfo-goodies" <zeroclickinfo-goodies@noreply.github.com> 
Cc: "hollingsworthd" <ops@machinepublishers.com> 
Sent: Friday, November 15, 2013 11:28:16 AM 
Subject: Re: [zeroclickinfo-goodies] Frequency Spectrum (#252) 



In lib/DDG/Goodie/FrequencySpectrum.pm: 
> +
> +sub color_ranges(){
> +  #reference: https://en.wikipedia.org/wiki/Color
> +  return [
> +    [ "400000000000000", "479999999999999", "red" ],
> +    [ "480000000000000", "504999999999999", "orange" ],
> +    [ "505000000000000", "524999999999999", "yellow" ],
> +    [ "525000000000000", "574999999999999", "green" ],
> +    [ "575000000000000", "609999999999999", "cyan" ],
> +    [ "610000000000000", "667999999999999", "blue" ],
> +    [ "668000000000000", "714999999999999", "indigo" ],
> +    [ "715000000000000", "800000000000000", "violet" ],
> +    ];
> +};
> +
> +sub instrument_ranges(){ 


Is there a point to having () on these? 

— 
Reply to this email directly or view it on GitHub .