would nice to add a test for this